Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing audio tracks changes the text track if the text track was previously changed #514

Closed
baseballbrad3 opened this issue Sep 12, 2016 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@baseballbrad3
Copy link
Contributor

  • What version of Shaka Player are you using?
    2.0.0
    • Can you reproduce the issue with our latest release version?
      Yep
    • Can you reproduce the issue with the latest code from master?
      I have not tried, but I don't see any commits since 2.0.0's release.
  • Are you using the demo app or your own custom app?
    Custom app
    • If custom app, can you reproduce the issue using our demo app?
      Yep
  • What did you do?
    I enabled subtitles by clicking the "CC" button on the controls. I selected the "fr (subtitle)" text track. I then changed the audio track to "de" (it was "en" on initial playback). Upon changing the audio track to "de" the text track changed back to "en (subtitle)"
    • What content did you load?
      Angel One (multicode, multilingual) on the demo player (and our own content)
    • If standard demo asset, which one?
      Angel One (multicode, multilingual)
    • If custom asset, what manifest and license server URIs?
    • How did you interact with the content, if at all?
      Other than clicking "CC", no. I didn't need to seek or pause or anything like that.
  • What did you expect to happen?
    I expected the text track to remain on the "fr (subtitle)" track.
  • What actually happened?
    The text track changed to the "en (subtitle)" text track when the audio track changed.

We're seeing this on Firefox, Chrome, IE, and Edge. Our work around is to query Shaka for the current playing text track, change the audio track to the user's selection, then change the text track back to what it was before. It works well enough, but I wanted to bring this up.

@ismena
Copy link
Contributor

ismena commented Sep 12, 2016

Thanks for reporting, Brad, I'll look into it.

@ismena ismena self-assigned this Sep 12, 2016
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Sep 13, 2016
@ismena
Copy link
Contributor

ismena commented Sep 13, 2016

@baseballbrad3 Should be good now. Please let us know if you have any questions or issues.

joeyparrish pushed a commit that referenced this issue Oct 19, 2016
Closes #514

Change-Id: I6b1a15fca71bdd8db34b0945c59ecac56b2783df
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants