Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream start time increased by parsing in-band pssh when pssh present in manifest on Xbox One #5197

Closed
caridley opened this issue Apr 27, 2023 · 2 comments · Fixed by #5198
Closed

Stream start time increased by parsing in-band pssh when pssh present in manifest on Xbox One #5197

caridley opened this issue Apr 27, 2023 · 2 comments · Fixed by #5198
Assignees
@caridley
Labels
platform: Xbox Issues affecting Xbox priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.4

Comments

@caridley
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
yes

What version of Shaka Player are you using?
4.3.4

Can you reproduce the issue with our latest release version?
did not test

Can you reproduce the issue with the latest code from main?
yes

Are you using the demo app or your own custom app?
custom app

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Xbox One

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?
The important setting here is drm.parseInBandPssh = true

What did you do?
Play streams with pssh in the manifest with shaka 3.1.2 and 4.3.4 and measure start times for a large number of streams on Xbobx one.
When we upgraded from shaka 3.1.2 to 4.3.4 we noticed a 600 ms increase in stream start time on Xbox one for streams with pssh present in the manifest. We determined that the start time increase was caused by unnecessarily parsing the in-band pssh for these stream.

What did you expect to happen?
We expected stream start time to be the same with version 3.1.2 and 4.23.4

What actually happened?
There was a 600 ms increase in average tune time with shaka 4.3.4 on xbox one for streams with pssh in the manifest

We determined that the start time increase was caused by unnecessarily parsing the in-band pssh for these stream.

The problem does not occur when the setting drm.parseInbandPssh is false.
@caridley caridley added the type: bug Something isn't working correctly label Apr 27, 2023
@caridley
Copy link
Contributor Author

This can be fixed by NOT parsing in-band pssh when pssh is present in the manifest. We will submit a PR with the fix.

@caridley
Copy link
Contributor Author

The problem was introduced by this change #4478

@caridley caridley mentioned this issue Apr 27, 2023
Merged
@github-actions github-actions bot added this to the v4.4 milestone Apr 27, 2023
@avelad avelad added priority: P2 Smaller impact or easy workaround platform: Xbox Issues affecting Xbox labels Apr 27, 2023
theodab pushed a commit that referenced this issue Apr 28, 2023
@caridley
fix: unnecessary parsing of in-band pssh when pssh is in the manifest (…
05aa931 
…#5198)

When pssh is provided in the manifest we do not need to parse in-band pssh even if the drm.parseInbandPssh setting is true.

Fixes #5197
@github-actions github-actions bot mentioned this issue Apr 28, 2023
Merged
joeyparrish pushed a commit that referenced this issue May 30, 2023
@caridley @joeyparrish
fix: unnecessary parsing of in-band pssh when pssh is in the manifest (…
889cc68 
…#5198)

When pssh is provided in the manifest we do not need to parse in-band pssh even if the drm.parseInbandPssh setting is true.

Fixes #5197

Cherry-picked to v4.2.x
joeyparrish pushed a commit that referenced this issue May 30, 2023
@caridley @joeyparrish
fix: unnecessary parsing of in-band pssh when pssh is in the manifest (…
8d6494d 
…#5198)

When pssh is provided in the manifest we do not need to parse in-band pssh even if the drm.parseInbandPssh setting is true.

Fixes #5197

Backported to v4.3.x
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jun 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@caridley caridley

Labels
platform: Xbox Issues affecting Xbox priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging a pull request may close this issue.

fix: unnecessary parsing of in-band pssh when pssh is in the manifest caridley/shaka-player
2 participants
@caridley @avelad