Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to seek beyond live edge. Not corrected #5202

Closed
Wayne-Morgan opened this issue Apr 28, 2023 · 7 comments · Fixed by #6304 or #7010
Closed

Possible to seek beyond live edge. Not corrected #5202

Wayne-Morgan opened this issue Apr 28, 2023 · 7 comments · Fixed by #6304 or #7010
Labels
priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@Wayne-Morgan
Copy link
Contributor

Wayne-Morgan commented Apr 28, 2023

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
4.3.5

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Custom app, but also reproduced in demo

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Various, but reproduced on Windows Chrome with the demo app

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?
Reproduced with "Live Sim (2s segments)"

What configuration are you using? What is the output of player.getConfiguration()?
Reproduced with default config

What did you do?
Seek beyond the seekable range, wait half a second, then do it again

const vidEl = document.getElementById("video");
vidEl.currentTime = vidEl.currentTime + 3600; 
setTimeout(()=>{vidEl.currentTime = vidEl.currentTime + 3600;}, 500);

What did you expect to happen?
The video to play from the live edge

What actually happened?
The player got stuck waiting.
I also tried seeking a smaller amount into the future (1 minute), and it recovered and started playing after a minute

The problem seems to be in MediaSourcePlayhead.onSeeking_()

if (!this.lastCorrectiveSeek_ || this.lastCorrectiveSeek_ < time - 1) {

The first seek out of range is corrected, but because the next happens within a second, the correction is simply discarded.

@Wayne-Morgan Wayne-Morgan added the type: bug Something isn't working correctly label Apr 28, 2023
@github-actions github-actions bot added this to the v4.4 milestone Apr 28, 2023
@avelad
Copy link
Collaborator

avelad commented Jun 9, 2023

@Wayne-Morgan are you interested on send a PR for it? Thanks!

@avelad avelad modified the milestones: v4.4, v4.5 Aug 31, 2023
@avelad avelad added flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P2 Smaller impact or easy workaround labels Sep 27, 2023
@avelad avelad modified the milestones: v4.5, v4.6 Oct 5, 2023
@avelad avelad modified the milestones: v4.6, v5.0 Nov 16, 2023
@avelad avelad modified the milestones: v4.7, v5.0 Dec 4, 2023
@CeilingFANC
Copy link
Contributor

Encountered the same issue.
I am interested on send a PR.

@joeyparrish
Copy link
Member

Please do! I'll assign the issue to you.

@avelad
Copy link
Collaborator

avelad commented Apr 8, 2024

@CeilingFANC Are you still interested in submitting the PR? Thanks!

@CeilingFANC
Copy link
Contributor

Yes. Just updated the test. How can I reopen the PR..

@avelad
Copy link
Collaborator

avelad commented Apr 10, 2024

What PR?

@avelad
Copy link
Collaborator

avelad commented Apr 10, 2024

@CeilingFANC I reopened your PR. Thanks!

avelad added a commit that referenced this issue Apr 12, 2024
Fixes #5202

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
avelad added a commit that referenced this issue Apr 15, 2024
Fixes #5202

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
avelad added a commit that referenced this issue Apr 15, 2024
Fixes #5202

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
joeyparrish added a commit to joeyparrish/shaka-player that referenced this issue May 6, 2024
PR shaka-project#6304 caused seeking timeouts in Cast Application Framework, in
v4.7.13, v4.8.0, and v4.8.1.

Reverts "fix: Correct playhead when seek beyond seekRange (shaka-project#6304)"

This reverts commit f91188e.

Reopens shaka-project#5202
@joeyparrish joeyparrish reopened this May 6, 2024
joeyparrish added a commit that referenced this issue May 6, 2024
PR #6304 caused seeking timeouts in Cast Application Framework, in
v4.7.13, v4.8.0, and v4.8.1.

Reverts "fix: Correct playhead when seek beyond seekRange (#6304)"

This reverts commit f91188e.

Reopens #5202
joeyparrish added a commit that referenced this issue May 6, 2024
PR #6304 caused seeking timeouts in Cast Application Framework, in
v4.7.13, v4.8.0, and v4.8.1.

Reverts "fix: Correct playhead when seek beyond seekRange (#6304)"

This reverts commit f91188e.

Reopens #5202
joeyparrish added a commit that referenced this issue May 7, 2024
PR #6304 caused seeking timeouts in Cast Application Framework, in
v4.7.13, v4.8.0, and v4.8.1.

Reverts "fix: Correct playhead when seek beyond seekRange (#6304)"

This reverts commit f91188e.

Reopens #5202
joeyparrish added a commit that referenced this issue May 7, 2024
PR #6304 caused seeking timeouts in Cast Application Framework, in
v4.7.13, v4.8.0, and v4.8.1.

Reverts "fix: Correct playhead when seek beyond seekRange (#6304)"

This reverts commit f91188e.

Reopens #5202
@avelad avelad modified the milestones: v4.8, v4.9, v4.10 May 28, 2024
@avelad avelad modified the milestones: v4.10, v4.11 Jul 1, 2024
@avelad avelad removed the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label Jul 9, 2024
@avelad avelad closed this as completed in dcc60f9 Jul 9, 2024
avelad added a commit that referenced this issue Jul 10, 2024
Previously, we added a 1 second "cooldown" period between attempts to
perform a corrective seek.
This was for the benefit of old v1 Chromecasts, which found the process
of seeking so slow that they would sometimes get stuck in an infinite
loop trying to start a presentation.
However, that cooldown period was causing issues in some situations
during seeking, so this PR removes the restriction on everything but
pre-Android Chromecast devices.

Fixes #4393
Fixes #5202

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
avelad added a commit that referenced this issue Jul 10, 2024
Previously, we added a 1 second "cooldown" period between attempts to
perform a corrective seek.
This was for the benefit of old v1 Chromecasts, which found the process
of seeking so slow that they would sometimes get stuck in an infinite
loop trying to start a presentation.
However, that cooldown period was causing issues in some situations
during seeking, so this PR removes the restriction on everything but
pre-Android Chromecast devices.

Fixes #4393
Fixes #5202

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
4 participants