Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codec-switching does not work on Chromecast yet #5306

Closed
joeyparrish opened this issue Jun 14, 2023 · 0 comments · Fixed by #5470
Closed

Codec-switching does not work on Chromecast yet #5306

joeyparrish opened this issue Jun 14, 2023 · 0 comments · Fixed by #5470
Labels
platform: Cast Issues affecting Cast devices priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.5

Comments

@joeyparrish
Copy link
Member

What browser and OS are you using?
Chromecast

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Chromecast Ultra, firmware 1.56, Chrome 90.0.4430.225

What did you do?
Run all tests on Chromecast in the lab

What actually happened?
Before PR #5301, the test "buffers partial TS video segments in sequence mode" would trigger codec-switching, even though this wasn't the intent of the test. The test would consistently fail with:

Shaka Error MEDIA.MEDIA_SOURCE_OPERATION_FAILED (4)
Error: Failed: video queue should be empty after destroy!

Codec-switching is not a complete feature yet, with only the low-level parts of MediaSourceEngine and StreamingEngine implemented. So this is not yet urgent.

Since the test fix in #5301, there are no tests that trigger this functionality.

We need tests to cover the low-level parts of codec-switching, and the functionality needs to be fixed and vetted on Chromecast devices.
@joeyparrish joeyparrish added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround platform: Cast Issues affecting Cast devices labels Jun 14, 2023
@github-actions github-actions bot added this to the v4.4 milestone Jun 14, 2023
@avelad avelad modified the milestones: v4.4, v4.5 Aug 31, 2023
@avelad avelad mentioned this issue Sep 11, 2023
Merged
@avelad avelad closed this as completed in 0078137 Oct 4, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@dave-nicholas @avelad
feat: Enable codec switching (shaka-project#5470)
f771f4f 
Closes: shaka-project#1528
Closes: shaka-project#1567
Closes: shaka-project#4379
Closes: shaka-project#5306

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 3, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
platform: Cast Issues affecting Cast devices priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.5
Development

Successfully merging a pull request may close this issue.

feat: Enable codec switching sky-hugolima/shaka-player-contrib
3 participants
@joeyparrish @avelad @shaka-bot