Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullp Resolution on Safari #5330

Closed
GabrielGallina opened this issue Jun 19, 2023 · 9 comments · Fixed by #5367
Closed

Nullp Resolution on Safari #5330

GabrielGallina opened this issue Jun 19, 2023 · 9 comments · Fixed by #5367
Labels
browser: Safari Issues affecting Safari or WebKit derivatives component: UI The issue involves the Shaka Player UI platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.4

Comments

@GabrielGallina
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
4.3.6

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Demo

What browser and OS are you using?
Safari iOS

What did you do?
Play any video on Safari and change de resolution, but appears just "nullp"
image

What did you expect to happen?
Appear resolutions to switch, like in other browsers

What actually happened?
When I'm using Safari, only the "nullp" resolution appears, I would like the other resolutions to appear as in other browsers to make the switch. I would like to understand if it could be some configuration or is it a shaka limitation
@GabrielGallina GabrielGallina added the type: bug Something isn't working correctly label Jun 19, 2023
@github-actions github-actions bot added this to the v4.4 milestone Jun 19, 2023
@avelad
Copy link
Collaborator

avelad commented Jun 20, 2023

@GabrielGallina can you share a stream so we can verify it? thank you!

@WINOFFRG
Copy link
Contributor

Duplicate of #4747 ?

@avelad
Copy link
Collaborator

avelad commented Jun 21, 2023

Maybe

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jun 21, 2023
@GabrielGallina
Copy link
Author

@WINOFFRG @avelad Yes, it seems to be the same problem, however it is from a year ago, so I would like to know if today there is something that can be done

@GabrielGallina
Copy link
Author

@avelad wich information from the stream would be needed to further evaluate?

@github-actions github-actions bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jun 21, 2023
@WINOFFRG
Copy link
Contributor

@GabrielGallina This isn't an issue but a limitation on apple devices. They support Native HLS Playback means the safari's default HLS Engine will be used. And that API doesn't expose any methods using which we can get the resolution values. You can simply turn off native playback by setting useNativeHlsOnSafari to false.

Refer https://shaka-player-demo.appspot.com/docs/api/shaka.extern.html#.PlayerConfiguration

By setting this to false, Shaka Player HLS Engine will be used without any limitations.

@avelad
Copy link
Collaborator

avelad commented Jun 21, 2023

@WINOFFRG , @GabrielGallina is using iOS, so no MSE...

@avelad avelad added browser: Safari Issues affecting Safari or WebKit derivatives platform: iOS Issues affecting iOS labels Jun 21, 2023
@avelad
Copy link
Collaborator

avelad commented Jun 27, 2023

On iOS/ipadOS, the preference is to use Safari's native HLS, but it does not return height/width information, so this information is not returned at this point. Thanks!

@avelad avelad closed this as completed Jun 27, 2023
@avelad avelad added status: working as intended The behavior is intended; this is not a bug and removed type: bug Something isn't working correctly labels Jun 27, 2023
@joeyparrish joeyparrish reopened this Jun 27, 2023
@joeyparrish
Copy link
Member

I would like to reopen this, to fix the UI. The information may not be available, and we may not be able to select a specific resolution, but the UI should not show "nullp".

@joeyparrish joeyparrish added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround and removed status: working as intended The behavior is intended; this is not a bug labels Jun 27, 2023
@avelad avelad mentioned this issue Jun 28, 2023
Merged
avelad added a commit that referenced this issue Jun 28, 2023
@avelad
fix(UI): Fix resolution selection on src= (#5367)
3863c73 
With this change, when we are in src= mode we only leave the automatic
mode in the resolution selector, since we will not be able to change the
resolution.

Fixes #5330
joeyparrish pushed a commit that referenced this issue Jul 20, 2023
@avelad @joeyparrish
fix(UI): Fix resolution selection on src= (#5367)
5118b24 
With this change, when we are in src= mode we only leave the automatic
mode in the resolution selector, since we will not be able to change the
resolution.

Fixes #5330
joeyparrish pushed a commit that referenced this issue Jul 20, 2023
@avelad @joeyparrish
fix(UI): Fix resolution selection on src= (#5367)
b570e92 
With this change, when we are in src= mode we only leave the automatic
mode in the resolution selector, since we will not be able to change the
resolution.

Fixes #5330
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
browser: Safari Issues affecting Safari or WebKit derivatives component: UI The issue involves the Shaka Player UI platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging a pull request may close this issue.

fix(UI): Fix resolution selection on src= avelad/shaka-player
4 participants
@joeyparrish @avelad @WINOFFRG @GabrielGallina