Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi period VOD with gaps in the timeline #537

Closed
erankor opened this issue Sep 30, 2016 · 6 comments
Closed

Multi period VOD with gaps in the timeline #537

erankor opened this issue Sep 30, 2016 · 6 comments
Assignees
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue type: bug Something isn't working correctly

Comments

@erankor
Copy link

erankor commented Sep 30, 2016

Hi,

I've been testing several different DASH manifest types - all combinations of:

  1. live / vod
  2. multi / single period
  3. segment timeline / template / list

All combinations worked fine except one - multi period vod that uses SegmentTemplate.
What happens is that the player hangs after the first period - it does not load the init segment nor the fragments of the second period.
This is the stream URL:
http://lbd.kaltura.com:8001/mapped/playlist-saas.php/disc/1/type/vod/manifest.mpd

Oddly, the respective live URL is working:
http://lbd.kaltura.com:8001/mapped/playlist-saas.php/disc/1/type/live/manifest.mpd

The tests were executed on the demo player (v2.0.0-debug):
http://shaka-player-demo.appspot.com/demo/

All tests were performed on Chrome v53.

Thank you,

Eran

@joeyparrish joeyparrish self-assigned this Oct 4, 2016
@joeyparrish
Copy link
Member

I have reproduced this on Chrome for Linux. It appears that your content has gaps in between the periods. This is not supported. There should be no gaps in the timeline. Please report this as a bug to Kaltura.

@joeyparrish joeyparrish added type: bug Something isn't working correctly type: external An issue with an external dependency; not our issue; sometimes kept open for tracking labels Oct 4, 2016
@joeyparrish joeyparrish changed the title Multi period VOD with SegmentTemplate hangs Multi period VOD with gaps in the timeline Oct 4, 2016
@erankor
Copy link
Author

erankor commented Oct 5, 2016

@joeyparrish, thank you for your reply !
I am from Kaltura... :)

Can you please explain what are the gaps you are seeing ?
Because I tested it now, and I don't see any gaps -

  • the duration of the first period in the MPD is 83.049
  • the earliest presentation time of the first fragment (in the sidx box) is 0
  • the earliest presentation time of the last fragment of the first period (fragment-9-v1-x2.m4s) is 0x006df927
  • the sum of frame durations in this fragment is: 0xbbb * 0x58 + 0xb7b = 0x413C3

therefore - (last PTS of first period) - (first PTS of first period) = 0x6df927 + 0x413C3 = 0x720CEA = 7474410.
the timescale in the sidx box is 90000, so we get 7474410 / 90000 = 83.049, which is exactly what is stated in the MPD.
I also checked the PTS delay in the trun atom of the first and last frames of the period, and both have 0x1776, so that shouldn't be a problem either.
I didn't check the other periods, because, as I previously wrote, no fragment of the second period is being pulled from the server.

Thanks again,

Eran

@PatrikCarlander
Copy link

http://lbd.kaltura.com:8001/mapped/playlist-saas.php/disc/1/type/vod/manifest.mpd
Your stream will play before commit 0df1ab0
Or you can comment out code line 855, 856, 857 and 860 in streaming_engine.js
It's related to bug #545

@ismena ismena added status: duplicate A duplicate of another issue; should be closed after linking to the original issue and removed type: external An issue with an external dependency; not our issue; sometimes kept open for tracking labels Oct 11, 2016
@ismena
Copy link
Contributor

ismena commented Oct 11, 2016

That's right, this had the same problem as #545.

@erankor I tested your stream with the fix and it seems to be fine.
(I also liked the video :) ).

Let me know if you have any questions.

@joeyparrish
Copy link
Member

joeyparrish commented Oct 12, 2016

It seems I misdiagnosed your stream. Sorry about that!

@erankor
Copy link
Author

erankor commented Oct 12, 2016

No problem, glad this was resolved.
Thanks everyone !

joeyparrish pushed a commit that referenced this issue Oct 19, 2016
Our new logic calculating bufferedAhead value doesn't work when
it comes to switching periods for content with SegmentTemplates.
This change partially reorders code from the 12c07efc change.

Closes #545
Closes #537

Change-Id: I1d9c3ab8a185d0a3f419bbc442b366e697115dd2
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

5 participants