Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of internal-error key status #539

Closed
joeyparrish opened this issue Oct 5, 2016 · 0 comments
Closed

Fix handling of internal-error key status #539

joeyparrish opened this issue Oct 5, 2016 · 0 comments
Assignees
@ismena
Labels
component: EME The issue involves the Encrypted Media Extensions web API status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.1.0

Comments

@joeyparrish
Copy link
Member

We have been operating under the assumption that the internal-error key status should not happen unless something catastrophic happens in the CDM. This is not true.

We should treat the keys marked internal-error the same as output-restricted: ignore tracks that require those keys. So long as there are usable keys, we should be able to play.

shaka.util.Error.Code.INTERNAL_ERROR_KEY_STATUS should be removed.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Oct 5, 2016
@joeyparrish joeyparrish added this to the v2.1.0 milestone Oct 5, 2016
@ismena ismena self-assigned this Oct 5, 2016
joeyparrish pushed a commit that referenced this issue Oct 19, 2016
@ismena @joeyparrish
Fix handling of internal-error key status.
ddabe10 
Closes #539.

Change-Id: I3ff30167034b4aed2bd390fc901e9466f6dd12c6
@TheModMaker TheModMaker added the component: EME The issue involves the Encrypted Media Extensions web API label Feb 1, 2017
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ismena ismena

Labels
component: EME The issue involves the Encrypted Media Extensions web API status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
4 participants
@TheModMaker @ismena @joeyparrish @shaka-bot