Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Accessibility #552

Closed
dovematrix opened this issue Oct 14, 2016 · 2 comments
Closed

Provide Accessibility #552

dovematrix opened this issue Oct 14, 2016 · 2 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.1.0

Comments

@dovematrix
Copy link

The WAVE toolbar for Chrome reports two accessibility errors - missing form labels on the scrub bar and volume control.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Oct 14, 2016
@joeyparrish joeyparrish added this to the v2.1.0 milestone Oct 14, 2016
@joeyparrish
Copy link
Member

Thank you for letting us know! Accessibility is important, but we have not had any rigorous testing around that.

Is this the extension you are using? http://wave.webaim.org/extension/ I want to make sure we can reproduce your results correctly.

@dovematrix
Copy link
Author

Thanks, yes that is correct.

@joeyparrish joeyparrish self-assigned this Oct 17, 2016
joeyparrish added a commit that referenced this issue Oct 19, 2016
@joeyparrish
Fix accessibility issues
3e1e80c 
Found by WAVE Chrome extension:
 - Add lang to html elements
 - Do not use label for non-inputs
 - Add invisible labels on video inputs, just for screen readers

Closes #552

Change-Id: I68f96fd92d33b2927da5ec52fd6c22527635c795
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
3 participants
@dovematrix @joeyparrish @shaka-bot