fix(Demo): Allow com.apple.fps.1_0 in the custom DRM System field #5600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
component: demo page
|
Incremental code coverage: No instrumented code was changed. |
joeyparrish
requested changes
Sep 5, 2023
demo/custom.js
Outdated
| @@ -407,9 +407,14 @@ shakaDemo.Custom = class { | |||
| const licenseServerURL = licenseServerUrlInput.value; | |||
| const customDRMSystem = customDrmSystemInput.value; | |||
| if (licenseServerURL) { | |||
| const filterFairplay = | |||
There was a problem hiding this comment.
I don't like this solution. Instead of filtering out fairplay from the loop when we add it in custom, I think it would be best if custom suppressed the entire loop. Let's move the loop to the else clause of if (customDRMSystem).
joeyparrish
approved these changes
Sep 5, 2023
joeyparrish
changed the title
joeyparrish
changed the title
joeyparrish
pushed a commit
that referenced
this pull request
Sep 5, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Sep 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.