fix: Fix compiled-mode error formatting #5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We declare shaka.util.Error to extend the native Error, but only supplied a message field in uncompiled and debug modes. This broke the Jasmine test framework when it tried to extract error message information from a compiled-mode shaka.util.Error object. Now we always supply a message object, and merely skip the fancy enum formatting in compiled mode.
|
Incremental code coverage: 100.00% |
avelad
approved these changes
Sep 8, 2023
joeyparrish
added a commit
that referenced
this pull request
Sep 13, 2023
We declare shaka.util.Error to extend the native Error, but only supplied a message field in uncompiled and debug modes. This broke the Jasmine test framework when it tried to extract error message information from a compiled-mode shaka.util.Error object. Now we always supply a message object, and merely skip the fancy enum formatting in compiled mode.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We declare shaka.util.Error to extend the native Error, but only supplied a message field in uncompiled and debug modes. This broke the Jasmine test framework when it tried to extract error message information from a compiled-mode shaka.util.Error object.
Now we always supply a message object, and merely skip the fancy enum formatting in compiled mode.