fix(HLS): Show WebVTT subtitles with X-TIMESTAMP-MAP in segments mode #5643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
theodab
requested changes
Sep 12, 2023
lib/text/vtt_text_parser.js
Outdated
| @@ -72,8 +84,8 @@ shaka.text.VttTextParser = class { | |||
| // HLS content, which should use X-TIMESTAMP-MAP and periodStart instead. | |||
| let offset = time.vttOffset; | |||
|
|
|||
| // Only use 'X-TIMESTAMP-MAP' in sequence mode, as that is currently | |||
| // shorthand for HLS. Note that an offset based on the first video | |||
| // Only use 'X-TIMESTAMP-MAP' in sequence mode or HLS. | |||
There was a problem hiding this comment.
I don't think this comment is accurate. It makes it sound like we are using X-TIMESTAMP-MAP in all HLS, but in reality we still don't parse the tag in segment mode HLS.
We are merely taking the presence of an X-TIMESTAMP-MAP tag as a signal that the offset is to be calculated differently in segment mode HLS, correct?
It might be better to have a short explanation inside the new clause below, and just remove the mention of HLS from this comment entirely.
|
Incremental code coverage: 98.21% |
theodab
approved these changes
Sep 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.