Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TTML): Fix wrong writing-mode in nested cues #5646

Merged
merged 1 commit into from Sep 12, 2023
Merged

fix(TTML): Fix wrong writing-mode in nested cues #5646

merged 1 commit into from Sep 12, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Sep 12, 2023

No description provided.

@avelad
Copy link
Collaborator Author

avelad commented Sep 12, 2023 •
edited

TTML

<tt xmlns="http://www.w3.org/ns/ttml"
    xmlns:ttp="http://www.w3.org/ns/ttml#parameter"
    xmlns:tts="http://www.w3.org/ns/ttml#styling"
    xmlns:ttm="http://www.w3.org/ns/ttml#metadata"
    xmlns:xml="http://www.w3.org/XML/1998/namespace">
<head>
  <layout>
    <region
      xml:id="vert_right" 
      tts:extent="100% 100%" tts:origin="2% 5%"
      tts:writingMode="tbrl"/>
    <region 
      xml:id="bottom"
      tts:extent="100% 100%" tts:origin="0% 40%"
      tts:displayAlign="center"/>
  </layout>
</head>
<body>
  <div>
    <p begin="00:00:01.000" end="00:00:04.000" region="vert_right">グーグルは<span tts:textCombine="all">1998</span>年に<span tts:ruby="container"><span tts:ruby="base">創業</span><span tts:ruby="text">そうぎょう</span></span>しました</p>
    <p begin="00:00:05.000" end="00:00:09.000" region="bottom">グーグルは1998年に<span tts:ruby="container"><span tts:ruby="base">創業</span><span tts:ruby="text">そうぎょう</span></span>しました</p>
  </div>
</body>
</tt>

Before:

Captura de pantalla 2023-09-12 a las 16 52 52

After:

Captura de pantalla 2023-09-12 a las 16 52 31

@avelad avelad added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround labels Sep 12, 2023
@avelad avelad added this to the v4.5 milestone Sep 12, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 3a4f108 into shaka-project:main Sep 12, 2023
21 checks passed
@shaka-bot shaka-bot mentioned this pull request Sep 12, 2023
Closed
@avelad avelad deleted the vertical-rendering branch September 12, 2023 19:23
joeyparrish pushed a commit that referenced this pull request Sep 13, 2023
@avelad @joeyparrish
fix(TTML): Fix wrong writing-mode in nested cues (#5646)
521c239
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Sep 13, 2023
@avelad @joeyparrish
fix(TTML): Fix wrong writing-mode in nested cues (#5646)
e125e53
@shaka-bot shaka-bot mentioned this pull request Sep 13, 2023
Merged
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 11, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avelad @shaka-bot @littlespex