Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Fix audio and video out of sync #5658

Merged
merged 1 commit into from
Sep 14, 2023
Merged

fix(HLS): Fix audio and video out of sync #5658

merged 1 commit into from
Sep 14, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Sep 14, 2023

Fixes #5584
Fixes #5013
Fixes #5397

timestampOffset calculation is no longer necessary in the HLS parser because we introduce recently some change in MediaSourceEngine to calculate the timestampOffset

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Sep 14, 2023
@avelad avelad added this to the v4.5 milestone Sep 14, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@joeyparrish
Copy link
Member

timestampOffset calculation is no longer necessary in the HLS parser because we introduce recently some change in MediaSourceEngine to calculate the timestampOffset

Which branches have that change? Only those branches should get this fix cherry-picked. This fix may break other branches.

@avelad
Copy link
Collaborator Author

avelad commented Sep 14, 2023

timestampOffset calculation is no longer necessary in the HLS parser because we introduce recently some change in MediaSourceEngine to calculate the timestampOffset

Which branches have that change? Only those branches should get this fix cherry-picked. This fix may break other branches.

Only 4.3 and 4.4

@avelad avelad merged commit 4cc4143 into shaka-project:main Sep 14, 2023
20 of 21 checks passed
@shaka-bot shaka-bot mentioned this pull request Sep 14, 2023
Closed
joeyparrish pushed a commit that referenced this pull request Sep 14, 2023
@avelad @joeyparrish
fix(HLS): Fix audio and video out of sync (#5658)
7df352d 
Fixes #5584
Fixes #5013
Fixes #5397

timestampOffset calculation is no longer necessary in the HLS parser
because we introduce recently some change in MediaSourceEngine to
calculate the timestampOffset

Backported to v4.4.x and v4.3.x
@shaka-bot shaka-bot mentioned this pull request Sep 14, 2023
Merged
@joeyparrish
Copy link
Member

Which branches have that change? Only those branches should get this fix cherry-picked. This fix may break other branches.

Only 4.3 and 4.4

This did not cherry-pick cleanly to v4.3.x, and I am not familiar with the change you're referencing. Can you please reimplement this in a PR against v4.3.x if it's necessary?

@avelad avelad deleted the hls-video-audio-sync branch September 15, 2023 06:46
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix(HLS): Fix audio and video out of sync (#5658)
cb9789e 
Fixes #5584
Fixes #5013
Fixes #5397

timestampOffset calculation is no longer necessary in the HLS parser
because we introduce recently some change in MediaSourceEngine to
calculate the timestampOffset

Backported to v4.4.x and v4.3.x
This was referenced Sep 21, 2023
Merged
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 13, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.5
3 participants
@avelad @shaka-bot @joeyparrish