Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live stream audio and video out of sync #5397

Closed
Andekas opened this issue Jul 5, 2023 · 1 comment · Fixed by #5658
Closed

Live stream audio and video out of sync #5397

Andekas opened this issue Jul 5, 2023 · 1 comment · Fixed by #5658
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.5

Comments

@Andekas
Copy link

Andekas commented Jul 5, 2023

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
Latest.

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Demo app

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Chrome and Edge, both Mac and Windows.

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

https://router.euddn.net/95b879fc5407bb2fc4ae3a1c74d69466/smil:live1.smil/playlist.m3u8?c=8000

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

Open live stream, let it play about 5 minutes

What did you expect to happen?
Live stream to play with audio and video in sync

What actually happened?

After about 5 minutes audio and video get out of sync.
The problem occurs in latest release and also on main, but in 4.3.2 everything works as expected (audio and video are in sync).
@Andekas Andekas added the type: bug Something isn't working correctly label Jul 5, 2023
@avelad avelad added component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Jul 5, 2023
@avelad avelad added this to the v4.4 milestone Jul 5, 2023
@avelad
Copy link
Member

avelad commented Jul 5, 2023

@joeyparrish can you review it?

@avelad avelad modified the milestones: v4.4, v4.5 Aug 31, 2023
@avelad avelad mentioned this issue Sep 14, 2023
Merged
avelad added a commit that referenced this issue Sep 14, 2023
@avelad
fix(HLS): Fix audio and video out of sync (#5658)
4cc4143 
Fixes #5584
Fixes #5013
Fixes #5397

timestampOffset calculation is no longer necessary in the HLS parser
because we introduce recently some change in MediaSourceEngine to
calculate the timestampOffset
joeyparrish pushed a commit that referenced this issue Sep 14, 2023
@avelad @joeyparrish
fix(HLS): Fix audio and video out of sync (#5658)
7df352d 
Fixes #5584
Fixes #5013
Fixes #5397

timestampOffset calculation is no longer necessary in the HLS parser
because we introduce recently some change in MediaSourceEngine to
calculate the timestampOffset

Backported to v4.4.x and v4.3.x
joeyparrish pushed a commit that referenced this issue Oct 4, 2023
@avelad @joeyparrish
fix(HLS): Fix audio and video out of sync (#5658)
cb9789e 
Fixes #5584
Fixes #5013
Fixes #5397

timestampOffset calculation is no longer necessary in the HLS parser
because we introduce recently some change in MediaSourceEngine to
calculate the timestampOffset

Backported to v4.4.x and v4.3.x
@Andekas Andekas mentioned this issue Oct 23, 2023
Closed
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 13, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 13, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
fix(HLS): Fix audio and video out of sync (shaka-project#5658)
d54b44f 
Fixes shaka-project#5584
Fixes shaka-project#5013
Fixes shaka-project#5397

timestampOffset calculation is no longer necessary in the HLS parser
because we introduce recently some change in MediaSourceEngine to
calculate the timestampOffset
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.5
Development

Successfully merging a pull request may close this issue.

fix(HLS): Fix audio and video out of sync avelad/shaka-player
3 participants
@Andekas @avelad @shaka-bot