Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Skip segments without duration and without partial segments #5705

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix(HLS): Skip segments without duration and without partial segments #5705

merged 1 commit into from
Oct 2, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 2, 2023

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Oct 2, 2023
@avelad avelad added this to the v4.5 milestone Oct 2, 2023
@avelad avelad merged commit f53d50d into shaka-project:main Oct 2, 2023
19 of 20 checks passed
@shaka-bot shaka-bot mentioned this pull request Oct 2, 2023
Closed
@avelad avelad deleted the preload-without-uri branch October 2, 2023 08:23
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 75.00%

joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix(HLS): Skip segments without duration and without partial segments (…
d41ce61 
…#5705)
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix(HLS): Skip segments without duration and without partial segments (…
96dfcc6 
…#5705)
@shaka-bot shaka-bot mentioned this pull request Sep 21, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix(HLS): Skip segments without duration and without partial segments (…
eedad19 
…#5705)
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix(HLS): Skip segments without duration and without partial segments (…
ac9151a 
…shaka-project#5705)
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 1, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab