Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shaka player does not play video when play button is pressed #600

Closed
sridhardvvce opened this issue Nov 19, 2016 · 22 comments
Closed

Shaka player does not play video when play button is pressed #600

sridhardvvce opened this issue Nov 19, 2016 · 22 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated status: bad content Caused by invalid, broken, or unsupported content
Milestone
v2.1.0

Comments

@sridhardvvce
Copy link

Hi,

This is continuation of issue #585 .

@joeyparrish I have updated the latest code.

If I play the video several times the issue will be reproduced 1 or 2 times (say 1 out of 10 times). When the video is not played if I seek a little the video starts playing.

Since the #585 ticket was closed I raised a new ticket.

Please help in fixing the issue
@joeyparrish joeyparrish self-assigned this Nov 29, 2016
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Nov 29, 2016
@joeyparrish
Copy link
Member

@sridhardvvce, can you please test something for me? I have been working on a bug today that may be related.

In lib/media/playhead.js, in the constructor, change this.startWatchdogTimer_() to this.onWatchdogTimer_(). I expect this will make the bug reproducible 10 out of 10 times. Please let me know if this is the case. If so, I should have a fix out soon.

@joeyparrish joeyparrish added status: waiting on response Waiting on a response from the reporter(s) of the issue and removed status: waiting on response Waiting on a response from the reporter(s) of the issue labels Nov 30, 2016
@joeyparrish
Copy link
Member

I believe this was fixed by 84fb9d4. If not, please let me know and we can reopen and investigate.

@joeyparrish joeyparrish modified the milestone: v2.1.0 Dec 6, 2016
@sridhard sridhard mentioned this issue Dec 24, 2016
Closed
@joeyparrish
Copy link
Member

As mentioned by @sridhardvvce in #637, this is not fixed yet. Reopening to investigate.

@joeyparrish joeyparrish reopened this Dec 27, 2016
@joeyparrish
Copy link
Member

Manifest link from the original issue, #585: https://s3-ap-southeast-1.amazonaws.com/learnyst/schools/1094/courses/6677/paid/25537/online/11/004_video_youtube_1mb_fdq7pg2zj7la7v7bke29webTrack.mpd

@joeyparrish
Copy link
Member

@sridhardvvce, I am unable to reproduce your issue using the latest code from master. Here's the link to what I'm doing to reproduce:

http://nightly.shaka-player-demo.appspot.com/demo/?asset=https://s3-ap-southeast-1.amazonaws.com/learnyst/schools/1094/courses/6677/paid/25537/online/11/004_video_youtube_1mb_fdq7pg2zj7la7v7bke29webTrack.mpd;play

Please provide detailed instructions to reproduce your issue. Here's a template:

  • What version of Shaka Player are you using?
    • Can you reproduce the issue with our latest release version?
    • Can you reproduce the issue with the latest code from master?
  • Are you using the demo app or your own custom app?
    • If custom app, can you reproduce the issue using our demo app?
  • What browser and OS are you using?
  • What did you do?
    • What content did you load?
      • If standard demo asset, which one?
      • If custom asset, what manifest and license server URIs?
    • How did you interact with the content, if at all?
  • What did you expect to happen?
  • What actually happened?

@joeyparrish joeyparrish added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Dec 27, 2016
@sridhard
Copy link

sridhard commented Jan 2, 2017

Hi,

What version of Shaka Player are you using?
Can you reproduce the issue with our latest release version?
//I have not tried using the release version

Can you reproduce the issue with the latest code from master?
//Yes. I am able to reproduce using the code from master

Are you using the demo app or your own custom app?
If custom app, can you reproduce the issue using our demo app?
//I am able to reproduce with demo app.

What browser and OS are you using?
//Mac and chrome. I faced the same issue with windows and chrome

What did you do?

What content did you load?
//I disabled the audo play mode and tried to play the content manually

If standard demo asset, which one?
If custom asset, what manifest and license server URIs?
//I used custom asset: https://s3-ap-southeast-1.amazonaws.com/learnyst/schools/1094/courses/6677/paid/25963/online/tst/2016-05-18_20.12_SSC_CGL_Quant_Advance_MathswebTrack.mpd

How did you interact with the content, if at all?
//Play the content manually (disable auto play). The issue will be reproduced once in 10-15 times

What did you expect to happen?
What actually happened?

@sridhard
Copy link

sridhard commented Jan 2, 2017

@joeyparrish

I have taken the latest master code and used the demo player to test the content. I have removed the auto play from the video tag in the index.html of demo player.

Steps:

  1. Launch the demo player and give the custom manifest URL(https://s3-ap-southeast-1.amazonaws.com/learnyst/schools/1094/courses/6677/paid/25963/online/tst/2016-05-18_20.12_SSC_CGL_Quant_Advance_MathswebTrack.mpd)

  2. Once the play button is displayed, wait for 5 seconds

  3. After 5-10 sec press the play button

  4. Repeat the process for 10-15 times.

Most of the times the content will be played when the play button is pressed. Some times it will display the loading progress and will not play the content. If we seek little bit then the content will start playing immediately

@joeyparrish joeyparrish removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 3, 2017
@sridhard
Copy link

sridhard commented Jan 7, 2017

@joeyparrish are you able to reproduce the issue? Do you need any help from me?

@sridhard
Copy link

sridhard commented Jan 7, 2017

@joeyparrish I have another video where this issue is reproduced most of the time https://s3-ap-southeast-1.amazonaws.com/learnyst/schools/1075/courses/8921/paid/42061/online/tst/2016-11-14_20_01__CGL17_Maths_Live_ClasswebTrack.mpd

@joeyparrish
Copy link
Member

Sorry for the delay. We've been really busy lately! We'll take a look and see if we can reproduce.

@TheModMaker
Copy link
Contributor

Here are the first few frame times of the audio stream, according to Chrome:

DTS PTS
0 -0.46439
0.23219 -0.23219
0.46439 0
0.69659 0.23219
0.92879 0.46439

The first few audio frames in the presentation have a PTS < 0, this causes Chrome's MSE to drop the early frames. Then Chrome's DTS vs PTS problem (see #377) will see the first frame at 0.46439 seconds, which is a gap that the video element will not jump. Additionally, the audio frames have a DTS > PTS, which Chrome is unsure if that is valid (see Chrome bug 354518).

So either this is Chrome's bug or the content is bad. I would suggest contacting the encoder that made the content to make sure that DTS <= PTS. If you could have PTS == DTS == 0 for the first frame, that would fix it.

@joeyparrish joeyparrish added status: bad content Caused by invalid, broken, or unsupported content and removed type: bug Something isn't working correctly labels Jan 24, 2017
@sridhard
Copy link

@joeyparrish I have tested this content with DASH player(http://dashif.org/reference/players/javascript/1.4.0/samples/dash-if-reference-player/) and it plays fine.

https://s3-ap-southeast-1.amazonaws.com/learnyst/schools/1075/courses/8921/paid/42061/online/tst/2016-11-14_20_01__CGL17_Maths_Live_ClasswebTrack.mpd

But this content fails to play without seeking in shaka player.
I have tried both shaka and DASH in chrome browser

@sridhard
Copy link

@TheModMaker with DASH reference player(http://dashif.org/reference/players/javascript/1.4.0/samples/dash-if-reference-player/) I am able to play the content.

In shaka player this content will play only when we seek initially.

@sridhard
Copy link

@joeyparrish @TheModMaker I have tried this content with expressplay SDK also. The content is played successfully. Can you please help in resolving the issue in shaka player

shaka-bot pushed a commit that referenced this issue Jan 30, 2017
@TheModMaker
Don't use segments to determine buffered ahead.
b88a98a 
Before, we would use the last appended segment to determine how much
we have buffered in StreamingEngine.  However, this causes a slight
difference between StreamingEngine and Playhead, which uses the
MediaSource buffered ranges.

If the video has a non-zero drift, StreamingEngine will think it has
buffered enough and will stop buffering, but Playhead will see the
buffered ranges slightly less than the goal and wait forever.

Issue #600

Change-Id: Ib68df5f8a84c15bcc8530f9db9c6b9a06e6a72ba
@TheModMaker
Copy link
Contributor

I just pushed a change that should fix the problem. Please try again with the latest from master.

@sridhard
Copy link

sridhard commented Feb 4, 2017

@TheModMaker I have tested the latest code. But still the issue exist.

@sridhard
Copy link

sridhard commented Feb 4, 2017

@TheModMaker this is the content URL: https://s3-ap-southeast-1.amazonaws.com/learnyst/schools/1075/courses/8921/paid/42061/online/tst/2016-11-14_20_01__CGL17_Maths_Live_ClasswebTrack.mpd

@sridhard
Copy link

sridhard commented Feb 4, 2017

@TheModMaker . Sorry. It was my mistake. The issue is resolved Thanks a lot

@joeyparrish
Copy link
Member

Thanks for retesting. Closing as resolved.

joeyparrish pushed a commit that referenced this issue Feb 10, 2017
@TheModMaker @joeyparrish
Don't use segments to determine buffered ahead (backport to v2.0.x)
c28509a 
Before, we would use the last appended segment to determine how much
we have buffered in StreamingEngine.  However, this causes a slight
difference between StreamingEngine and Playhead, which uses the
MediaSource buffered ranges.

If the video has a non-zero drift, StreamingEngine will think it has
buffered enough and will stop buffering, but Playhead will see the
buffered ranges slightly less than the goal and wait forever.

Issue #600

Based on Change-Id: Ib68df5f8a84c15bcc8530f9db9c6b9a06e6a72ba
@hussam-i-am
Copy link

@joeyparrish @TheModMaker I encountered this exact same issue using v2.0.6 as well as master on Chrome 57. Here's the sample stream: https://akadash0-test.akamaized.net/test/clear/test-multi-audio/master.mpd

It is reproducible in the demo page, and verified that this started occurring between v2.0.0 and v2.0.1

Thoughts?

@TheModMaker
Copy link
Contributor

@hghazzi First I am getting a 403 error for the manifest. Please post an accessible manifest.

Also please open a new issue.

@hussam-i-am hussam-i-am mentioned this issue Mar 15, 2017
Closed
@hussam-i-am
Copy link

@TheModMaker Done. Stream worked fine for me

@hussam-i-am hussam-i-am mentioned this issue Apr 10, 2017
Closed
@joeyparrish joeyparrish added zzz-outdated: Chrome PTS/DTS bug Related to the Chrome PTS/DTS bugs that were present from 2016 - 2019; do not use for new issues and removed zzz-outdated: Chrome PTS/DTS bug Related to the Chrome PTS/DTS bugs that were present from 2016 - 2019; do not use for new issues labels Aug 15, 2017
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated status: bad content Caused by invalid, broken, or unsupported content
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
6 participants
@hussam-i-am @TheModMaker @sridhardvvce @sridhard @joeyparrish @shaka-bot