Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI): Hide resolution overflow menu button if there's only one choice #6004

Merged
merged 1 commit into from Dec 12, 2023
Merged

feat(UI): Hide resolution overflow menu button if there's only one choice #6004

merged 1 commit into from Dec 12, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Dec 8, 2023

Fixes 628bb63

@avelad avelad changed the title feat(UI): Hide overflow menu button if there's only one choice feat(UI): Hide resolution overflow menu button if there's only one choice Dec 8, 2023
@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Dec 8, 2023
@avelad avelad added this to the v5.0 milestone Dec 8, 2023
@avelad avelad requested a review from theodab December 8, 2023 13:15
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@theodab theodab merged commit 8649e7e into shaka-project:main Dec 12, 2023
19 of 20 checks passed
@shaka-bot shaka-bot mentioned this pull request Dec 12, 2023
Merged
@avelad avelad deleted the ui-resolution branch December 16, 2023 15:40
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Feb 10, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avelad @shaka-bot @theodab