Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI interactivity is using the wrong event listeners - really bad experience for mobile #6027

Closed
MarianoFacundoArch opened this issue Dec 26, 2023 · 3 comments · Fixed by #6050
Closed

UI interactivity is using the wrong event listeners - really bad experience for mobile #6027

MarianoFacundoArch opened this issue Dec 26, 2023 · 3 comments · Fixed by #6050
Labels
component: UI The issue involves the Shaka Player UI platform: Android Issues affecting Android platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone
v4.9

Comments

@MarianoFacundoArch
Copy link
Contributor

With customUI, I noticed the following problems:

When controls were hidden, and I am on iOS or Android, I try to scroll down (player is on an iframe), but instead, the event is cancelled and the UI controls are shown. That is not intended, the intended behavior in that case is to respond to the scroll event. I imagine the wrong event listener is being used.

The other problem is with the tapToSeek, when it is enabled, the scrolling when scrolling from the laterals is blocked, so had to disable the entire feature.

I guess the UI is using the wrong event listeners.
@MarianoFacundoArch MarianoFacundoArch added the type: bug Something isn't working correctly label Dec 26, 2023
@shaka-bot shaka-bot added this to the v5.0 milestone Dec 26, 2023
@avelad avelad added component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Jan 8, 2024
@avelad avelad mentioned this issue Jan 8, 2024
Merged
@avelad
Copy link
Collaborator

avelad commented Jan 8, 2024

@MarianoFacundoArch partial fix #6050

avelad added a commit that referenced this issue Jan 9, 2024
@avelad
fix(UI): Fix the scrolling when scrolling from the laterals when seek…
df05692 
…OnTaps is enabled (#6050)

Fixes #6027
@avelad avelad reopened this Jan 9, 2024
avelad added a commit that referenced this issue Jan 9, 2024
@avelad
fix(UI): Fix the scrolling when scrolling from the laterals when seek…
4564233 
…OnTaps is enabled (#6050)

Fixes #6027
@avelad avelad added platform: Android Issues affecting Android platform: iOS Issues affecting iOS labels Jan 17, 2024
@avelad
Copy link
Collaborator

avelad commented Apr 25, 2024

Can you share a minimal code to reproduce the issue? Thanks!

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Apr 25, 2024
@avelad avelad modified the milestones: v4.8, v4.9 Apr 26, 2024
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI platform: Android Issues affecting Android platform: iOS Issues affecting iOS priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.9
3 participants
@avelad @shaka-bot @MarianoFacundoArch