Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muting/unmuting ads won't affect video and vice versa #6071

Closed
Andekas opened this issue Jan 10, 2024 · 1 comment · Fixed by #6073
Closed

Muting/unmuting ads won't affect video and vice versa #6071

Andekas opened this issue Jan 10, 2024 · 1 comment · Fixed by #6073
Assignees
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Andekas
Copy link

Andekas commented Jan 10, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

Not related

What version of Shaka Player are you using?

4.7.3

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Doesn't seem to matter. WIndows, Chrome for example, but seems to be browser independent.

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not related

What are the manifest and license server URIs?

Demo app is good, VMAP ad tags from https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/tags

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

Play video with ads

What did you expect to happen?
When ads/video start muted and I unmute ad/video, I expect video/ad to be unmuted also.
When ads/video start with sound and I mute ad/video, I expect video/ad to be muted also.

What actually happened?

Muting / unmuting applies only to currently playing media. Next elements (video, other ads) are not affected.

For example:

  • when video starts muted and I have midroll with three ads and I unmute the first ad, other two ads and proceeding video will remain muted.
  • when I have preroll, starting with sound and I mute the preroll, video will still continue with sound
  • etc
@Andekas Andekas added the type: bug Something isn't working correctly label Jan 10, 2024
@avelad avelad added component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Jan 10, 2024
@shaka-bot shaka-bot added this to the v5.0 milestone Jan 10, 2024
@avelad
Copy link
Collaborator

avelad commented Jan 10, 2024

@Andekas PR to fix it: #6073

@avelad avelad self-assigned this Jan 10, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 10, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants