Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Fix muting/unmuting ads won't affect video and vice versa #6073

Merged
merged 1 commit into from Jan 10, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jan 10, 2024

Fixes #6071

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Jan 10, 2024
@avelad avelad added this to the v5.0 milestone Jan 10, 2024
@avelad avelad merged commit 01a217f into shaka-project:main Jan 10, 2024
16 of 20 checks passed
@avelad avelad deleted the muting-ads-video branch January 10, 2024 16:32
@Andekas
Copy link

Andekas commented Jan 11, 2024

@avelad Thanks, this was really fast. Works great!

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 10, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Muting/unmuting ads won't affect video and vice versa
4 participants