Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix PES rollover in TS #6363

Merged
merged 3 commits into from
Mar 29, 2024
Merged

fix: Fix PES rollover in TS #6363

merged 3 commits into from
Mar 29, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Mar 25, 2024

Related to #6320 (comment)

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: transmuxer The issue involves our built-in transmuxer labels Mar 25, 2024
@avelad avelad added this to the v5.0 milestone Mar 25, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Mar 25, 2024 •
edited
Loading

Incremental code coverage: 100.00%

joeyparrish
joeyparrish requested changes Mar 25, 2024
View reviewed changes
lib/util/ts_parser.js Show resolved Hide resolved
@avelad avelad requested a review from joeyparrish March 26, 2024 08:39
@avelad avelad requested a review from joeyparrish March 27, 2024 07:13
@joeyparrish joeyparrish merged commit e8f37f0 into shaka-project:main Mar 29, 2024
16 checks passed
@shaka-bot shaka-bot mentioned this pull request Mar 29, 2024
Merged
@avelad avelad deleted the ts-rollover branch April 1, 2024 06:12
avelad added a commit that referenced this pull request Apr 8, 2024
@avelad
fix: Fix PES rollover in TS (#6363)
4ec646b 
Related to #6320 (comment)
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
avelad added a commit that referenced this pull request Apr 8, 2024
@avelad
fix: Fix PES rollover in TS (#6363)
6683811 
Related to #6320 (comment)
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
@avelad avelad mentioned this pull request Apr 9, 2024
Closed
@TommiRautanen
Copy link

@avelad can this fix be added to 4.3.x too? We were forced to update our Chromecast to use 4.6.16 but because of #6070 we may have to go back to 4.3.x but if we do, this TS rollover thing will be an issue for us again.

@avelad
Copy link
Member Author

avelad commented Apr 30, 2024

In 4.3.x mux.js is used and Shaka's transmuxer is not used, so the change cannot be migrated.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 28, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: transmuxer The issue involves our built-in transmuxer priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.
4 participants
@avelad @shaka-bot @TommiRautanen @joeyparrish