Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The refresh rate for the seekbar is TOO slow #6376

Closed
MarianoFacundoArch opened this issue Mar 29, 2024 · 8 comments · Fixed by #6386
Closed

The refresh rate for the seekbar is TOO slow #6376

MarianoFacundoArch opened this issue Mar 29, 2024 · 8 comments · Fixed by #6386
Assignees
@MarianoFacundoArch
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent type: enhancement New feature or request
Milestone
v4.8

Comments

@MarianoFacundoArch
Copy link
Contributor

The seekbar, when playing content, looks so unnatural, with small jumps.
How can I force you to update quickly? I thought of setting a timer with interval 50, but I don't see what method to call.
Thanks.
@MarianoFacundoArch MarianoFacundoArch added the type: bug Something isn't working correctly label Mar 29, 2024
@shaka-bot shaka-bot added this to the v5.0 milestone Mar 29, 2024
@avelad
Copy link
Collaborator

avelad commented Apr 1, 2024

It is currently not configurable, the default value is 0.125 seconds. See: https://github.com/shaka-project/shaka-player/blob/main/ui/controls.js#L190

@avelad avelad added type: question A question from the community status: waiting on response Waiting on a response from the reporter(s) of the issue and removed type: bug Something isn't working correctly labels Apr 1, 2024
@avelad avelad removed this from the v5.0 milestone Apr 1, 2024
@MarianoFacundoArch
Copy link
Contributor Author

Can we make this configurable? It does really look bad, no player has this delay, I've tried youtube, bitmovin, jwplayer.
We look like from the 90s with that refresh rate

@avelad
Copy link
Collaborator

avelad commented Apr 1, 2024

Are you interested in sending a PR to implement the configuration?

@MarianoFacundoArch
Copy link
Contributor Author

MarianoFacundoArch commented Apr 1, 2024 •
edited

Yes, I can do it! Let me try, this is my first commit to shaka, will keep you posted!

@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent and removed type: question A question from the community status: waiting on response Waiting on a response from the reporter(s) of the issue labels Apr 1, 2024
@MarianoFacundoArch
Copy link
Contributor Author

Done!
#6386

@shaka-bot shaka-bot added this to the Backlog milestone Apr 1, 2024
@MarianoFacundoArch
Copy link
Contributor Author

I got this error?

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this [failed invocation](https://github.com/shaka-project/shaka-player/pull/6386/checks?check_run_id=23307303530) of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MarianoFacundoArch
Copy link
Contributor Author

I signed the contract, how can we proceed to get this merged for next release?

@avelad avelad mentioned this issue Apr 2, 2024
Merged
@avelad
Copy link
Collaborator

avelad commented Apr 2, 2024

I signed the contract, how can we proceed to get this merged for next release?

I fixed some issues on your PR, you need add your name and email to https://github.com/shaka-project/shaka-player/blob/main/AUTHORS and https://github.com/shaka-project/shaka-player/blob/main/CONTRIBUTORS

@avelad avelad modified the milestones: Backlog, v5.0 Apr 2, 2024
avelad added a commit that referenced this issue Apr 3, 2024
@MarianoFacundoArch @avelad
feat(UI): Add config for refreshTickInSeconds (#6386)
dbdef5d 
Closes #6376

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarianoFacundoArch MarianoFacundoArch

Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Milestone
v4.8
Development

Successfully merging a pull request may close this issue.

feat(UI): Add config for refreshTickInSeconds MarianoFacundoArch/shaka-player
3 participants
@avelad @shaka-bot @MarianoFacundoArch