Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Add config for refreshTickInSeconds #6386

Merged
merged 3 commits into from Apr 3, 2024

Conversation

MarianoFacundoArch
Copy link
Contributor

@MarianoFacundoArch MarianoFacundoArch commented Apr 1, 2024

Closes #6376

Copy link

google-cla bot commented Apr 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@avelad avelad changed the title Support config variable refreshTickInSeconds feat(UI): Add config for refreshTickInSeconds Apr 2, 2024
@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent labels Apr 2, 2024
@avelad avelad added this to the v5.0 milestone Apr 2, 2024
@avelad
Copy link
Collaborator

avelad commented Apr 2, 2024

@MarianoFacundoArch
Copy link
Contributor Author

Hi! Thanks! It is done in two commits; please let me know when it is merged. I am willing to continue collaborating! :D
#6391
#6392

This was referenced Apr 2, 2024
@MarianoFacundoArch
Copy link
Contributor Author

@avelad Name added to this PR as requested; how do we proceed and get it merged?
Thanks!

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad
Copy link
Collaborator

avelad commented Apr 2, 2024

@avelad Name added to this PR as requested; how do we proceed and get it merged? Thanks!

We need a review from @joeyparrish or @theodab before merge it. Thanks!

@avelad avelad merged commit dbdef5d into shaka-project:main Apr 3, 2024
16 of 17 checks passed
@MarianoFacundoArch
Copy link
Contributor Author

When shall this be released? In which version?

@joeyparrish
Copy link
Member

If we don't do a new branch for v4.8, this would be out in v5.0, which we will be more cautious about. There are other things we want to break this year, like moving to TypeScript, so it's possible that v5.0 will be delayed for a while. If we create a v4.8.x branch without the breaking changes in it, your change would be in that branch and would be out sooner.

@joeyparrish
Copy link
Member

We will be releasing v4.8.0 soon.

@MarianoFacundoArch
Copy link
Contributor Author

Got it. Thank you @joeyparrish !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The refresh rate for the seekbar is TOO slow
5 participants