Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in TTML parsing for div with whitespace #646

Closed
TobbeEdgeware opened this issue Jan 4, 2017 · 1 comment
Closed

Bug in TTML parsing for div with whitespace #646

TobbeEdgeware opened this issue Jan 4, 2017 · 1 comment
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.1.0

Comments

@TobbeEdgeware
Copy link
Contributor

  • What version of Shaka Player are you using?
    Demo v 2.0.2-debug + Latest master (2017-01-05)

    • Can you reproduce the issue with our latest release version?
      Yes

    • Can you reproduce the issue with the latest code from master?
      Yes

  • Are you using the demo app or your own custom app?
    demo app

We had own content with empty ttml subtitles segment inside mp4 segments.
It contains a a body with an empty div element like

<body style="s0">
   <div region="r0">
   </div>
 </body>

The demo player shows Shaka Error INVALID_TEXT_CUE.

I've tracked this down to ttml_text_parser and its "Disregard empty elements" which does not allow white-space in an empty div.

I've made a patch and added a unit test for the patch. Will submit them.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jan 4, 2017
@joeyparrish
Copy link
Member

Thanks! Looking forward to your PR.

@joeyparrish joeyparrish added this to the v2.1.0 milestone Jan 4, 2017
@TobbeEdgeware TobbeEdgeware mentioned this issue Jan 9, 2017
Merged
joeyparrish pushed a commit that referenced this issue Jan 19, 2017
@tobbee @joeyparrish
Fix parsing of white-space-only div in TTML (#650)
9e35147 
A div element with no timing and only whitespace should be considered empty.

Closes #646
@TobbeEdgeware TobbeEdgeware mentioned this issue Jan 26, 2017
Closed
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
3 participants
@joeyparrish @shaka-bot @TobbeEdgeware