Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot create a Shaka Player in Cobalt #6517

Closed
MichaelSweden opened this issue Apr 30, 2024 · 3 comments · Fixed by #6518
Closed

Cannot create a Shaka Player in Cobalt #6517

MichaelSweden opened this issue Apr 30, 2024 · 3 comments · Fixed by #6518
Assignees
@MichaelSweden
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.9

Comments

@MichaelSweden
Copy link
Contributor

MichaelSweden commented Apr 30, 2024 •
edited
Loading

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?
Not related.

What version of Shaka Player are you using?
v4.8.1

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Own html page.

If custom app, can you reproduce the issue using our demo app?
Cannot use your demo app, it's not compatible with Cobalt.

What browser and OS are you using?
Cobalt browser (main branch) and Xubuntu.
The problem doesn't appear with Firefox or Chromium

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not applicable.

What are the manifest and license server URIs?
Don't come so far.

What configuration are you using? What is the output of player.getConfiguration()?
Default.

What did you do?
"var player = new shaka.Player(video)"

What did you expect to happen?
Get a shaka player object.

What actually happened?
Got an exception: "TypeError: Cannot read property 'toLowerCase' of undefined"

Can be derived to shaka.Player.constructor() -> shaka.util.PlayerConfiguration.createDefault() -> supportsSmoothCodecSwitching() -> isWindows()

I have a fix for it and can create a pull request.
@MichaelSweden MichaelSweden added the type: bug Something isn't working correctly label Apr 30, 2024
@avelad
Copy link
Collaborator

avelad commented Apr 30, 2024

@MichaelSweden Please send you PR! I'll review it asap. Thanks!

@avelad avelad added the priority: P2 Smaller impact or easy workaround label Apr 30, 2024
@avelad avelad added this to the v4.9 milestone Apr 30, 2024
@avelad
Copy link
Collaborator

avelad commented Apr 30, 2024

Maybe navigator.platform is null on that platform?

MichaelSweden added a commit to MichaelSweden/shaka-player that referenced this issue Apr 30, 2024
@MichaelSweden
fix: Handle non existing navigator.platform string (shaka-project#6517)
261ee4b
@MichaelSweden
Copy link
Contributor Author

Yes, navigator.platform doesn't exist in Cobalt browser.

@avelad avelad mentioned this issue Apr 30, 2024
Merged
avelad added a commit that referenced this issue Apr 30, 2024
@MichaelSweden @avelad
fix: Handle non existing navigator.platform string (#6517) (#6518)
f337e06 
This fix will make it possible to use v4.8 in Cobalt browser. The
problem is that navigator.platform doesn't exist in Cobalt browser.

Fixes #6517

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
@shaka-bot shaka-bot mentioned this issue Apr 30, 2024
Merged
avelad added a commit that referenced this issue May 6, 2024
@MichaelSweden @avelad
fix: Handle non existing navigator.platform string (#6517) (#6518)
feb176c 
This fix will make it possible to use v4.8 in Cobalt browser. The
problem is that navigator.platform doesn't exist in Cobalt browser.

Fixes #6517

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
@shaka-bot shaka-bot mentioned this issue May 6, 2024
Merged
joeyparrish pushed a commit that referenced this issue May 7, 2024
@MichaelSweden @avelad @joeyparrish
fix: Handle non existing navigator.platform string (#6517) (#6518)
9a3b047 
This fix will make it possible to use v4.8 in Cobalt browser. The
problem is that navigator.platform doesn't exist in Cobalt browser.

Fixes #6517

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
@shaka-bot shaka-bot mentioned this issue May 7, 2024
Merged
joeyparrish pushed a commit that referenced this issue May 7, 2024
@MichaelSweden @avelad @joeyparrish
fix: Handle non existing navigator.platform string (#6517) (#6518)
3747b8e 
This fix will make it possible to use v4.8 in Cobalt browser. The
problem is that navigator.platform doesn't exist in Cobalt browser.

Fixes #6517

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
@shaka-bot shaka-bot mentioned this issue May 7, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 29, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichaelSweden MichaelSweden

Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.9
Development

Successfully merging a pull request may close this issue.

fix: Handle non existing navigator.platform string (#6517) MichaelSweden/shaka-player
3 participants
@avelad @shaka-bot @MichaelSweden