feat: Add getNonDefaultConfiguration #6620
Merged
+86
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
avelad
force-pushed
the
getNonDefaultConfiguration
branch
from
71a7ca9
to
f2503a2
Compare
|
Incremental code coverage: 94.83% |
theodab
requested changes
May 17, 2024
theodab
approved these changes
May 17, 2024
joeyparrish
reviewed
May 17, 2024
| goog.asserts.assert(this.config_, 'Config must not be null!'); | ||
|
|
||
| const ret = this.defaultConfig_(); | ||
| shaka.util.PlayerConfiguration.mergeConfigObjects( |
There was a problem hiding this comment.
I don't see why this merge step is necessary. this.config_ should already follow the proper format, right? In fact, you don't even use the result ret here at all.
joeyparrish
reviewed
May 17, 2024
| }; | ||
|
|
||
| const changes = (object, base) => { | ||
| return Object.fromEntries( |
There was a problem hiding this comment.
Doesn't exist on Tizen, not polyfilled by Babel for testing AFAICT.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.