Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shaka player not auto hide control bar in fullscreen mode on Android device #663

Closed
yiningc opened this issue Jan 23, 2017 · 3 comments
Closed

shaka player not auto hide control bar in fullscreen mode on Android device #663

yiningc opened this issue Jan 23, 2017 · 3 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.2.0

Comments

@yiningc
Copy link

yiningc commented Jan 23, 2017

Chrome Version: 57.0.2970.0
OS: Android

This is not observed on other OS, only on Android. It not repro on HTML5

What steps will reproduce the problem?
(1) navigate to http://shaka-player-demo.appspot.com/demo/
(2) load any video
(3) switch to fullscreen mode

What is the expected result?
after a some seconds, control bar hide away

What happens instead?
control bar stays, not hide away
@joeyparrish
Copy link
Member

Thanks for filing!

I did some preliminary investigation. It appears that we may be missing some touch event in the UI somehow when we enter fullscreen mode. Only happens on Android because it depends on touch events.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jan 23, 2017
@joeyparrish joeyparrish added this to the v2.1.0 milestone Jan 23, 2017
@TheModMaker TheModMaker self-assigned this Feb 13, 2017
@TheModMaker
Copy link
Contributor

The problem is that phones do not have a mouse, but browsers simulate them. The browser will still fire mouse events (e.g. mousemove) and it will still use the CSS :hover pseudo-class. When you click the fullscreen button, the controls will get the :hover styles; however, the style doesn't get removed until you "click" somewhere else, even if you drag elsewhere.

So if we are getting touch events, we should override the :hover styles and hide the controls.

TheModMaker added a commit that referenced this issue Feb 24, 2017
@TheModMaker
Override hover styles when there are touch events.
a026f52 
When the user touches the demo controls (e.g. on a phone), the controls
will get the :hover pseudo-class.  However, this style doesn't get
removed until the user "clicks" somewhere else.  This causes the
controls to remain visible forever.

When we are getting touch events, we should override the :hover style
and hide the controls.  However, we should only do this so long as the
clicks are from touch events.  For touchscreen laptops (that have both
touch events and a mouse), we should still allow hovering over the
controls if they used the mouse.

Closes #663

Change-Id: I2705aa8fa9e59657b6fe3603c1826125ccce950a
@joeyparrish joeyparrish reopened this Jun 7, 2017
@joeyparrish
Copy link
Member

This appears to be happening again.

@joeyparrish joeyparrish modified the milestones: v2.2.0, v2.1.0 Jun 7, 2017
joeyparrish pushed a commit that referenced this issue Jun 15, 2017
@TheModMaker @joeyparrish
Fix fullscreen controls on phones.
f545df7 
Closes #663

Change-Id: Ieda41c62b1202f2636ecd258f487208b55034015
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
4 participants
@TheModMaker @joeyparrish @shaka-bot @yiningc