Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromecast support broken in v2.0.5, working in v2.0.2 #675

Closed
mthsmlk opened this issue Feb 2, 2017 · 3 comments
Closed

Chromecast support broken in v2.0.5, working in v2.0.2 #675

mthsmlk opened this issue Feb 2, 2017 · 3 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@mthsmlk
Copy link

mthsmlk commented Feb 2, 2017

Hi all,

i get an error in my custom receiver app. Maybe its a faulty configuration in Google Cast SDK Developer Console. So I receive no messages from custom receiver app to sender app.

  • What version of Shaka Player are you using?
    2.0.5

  • Are you using the demo app or your own custom app?
    Demo app adapted to own player. (Receiver-App / Shakaplayer)

  • If custom app, can you reproduce the issue using our demo app?
    Yes, I registred a receiver-app with source from: 'https://shaka-player-demo.appspot.com/demo/receiver_app.html'.
    So i can debugging this application.

  • What browser and OS are you using?
    Mac 10.11.6 / Chromecast Firmware: 1.22.78337 / Google Chrome Version 56.0.2924.87

  • What did you do?

  1. I implemented Shaka-Demo-Player in my application. That's works well.
  2. I tried Google Cast with demo receiverapp CC_APP_ID_ 658CCD53. That's works well, too.
  3. I registered my custom receiver-app. Get demo files: receiver_app.css, receiver_app.html, receiver_app.js + controls.js, demo_utils.js + shaka player 2.0.5 compiled script.
  4. I changed the CC_APP_ID_ to my custom receiver-app id. Videos are playing, but i get no messages (information about playback) from my castdevice / proxy.
  5. I tried a second custom receiver-app with hosted URL to 'http://shaka-player-demo.appspot.com/demo/receiver_app.html'
  6. Same problem/error like the first custom receiver-app.
  • What did you expect to happen?
    Sender App (Google Chrome Browser) should show video information from receiver-app like currentTime, duration and i want to interact my video over sender app/browser over seekbar.

  • What actually happened?
    I don't get information about duration, currentTime from receiver-app to sender-app. So i cant control video on Chromecast except volume. I debugged receiver-app and get this error:

Compiled version:
Exception: TypeError: this.a[b] is not a function at B.
b: "getPlayheadTimeAsDate"

Source of error: https://github.com/google/shaka-player/blob/master/lib/cast/cast_receiver.js#L328

I think the events don't fire because of this error. (https://github.com/google/shaka-player/blob/87c7d5d6651fe4f6f03de84d77c920e91c34a107/lib/cast/cast_utils.js#L111)

Why can i interactive with the Shaka Demo receiver app (Id:658CCD53)? Maybe hosted URL isn't 'http://shaka-player-demo.appspot.com/demo/receiver_app.html'... I don't get it.

I hope someone can help me.

Best regards,
molethiaz

@mthsmlk
Copy link
Author

mthsmlk commented Feb 2, 2017

Hello again,

i just downgraded shaka-script in sender & receiver app to V 2.0.2 and now i get no error anymore.

I saw method 'getPlayheadTimeAsDate' is not in PlayerGetterMethods Array:
https://github.com/google/shaka-player/blob/v2.0.2/lib/cast/cast_utils.js#L105

A workaround may be:

shaka.cast.CastUtils.PlayerGetterMethods.forEach(function(name) {
    if(typeof (this.player_)[name] === 'function') {
        update['player'][name] = /** @type {Object} */(this.player_)[name]();
    }
 }.bind(this));

@mthsmlk mthsmlk closed this as completed Feb 2, 2017
@joeyparrish joeyparrish reopened this Feb 2, 2017
@joeyparrish joeyparrish changed the title Chromecast sends no messages between custom receiver app and sender Chromecast support broken in v2.0.5, working in v2.0.2 Feb 2, 2017
@joeyparrish
Copy link
Member

Thank you for checking older versions and for reporting this issue. We should be able to get it fixed in our next release.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Feb 2, 2017
@joeyparrish joeyparrish added this to the v2.1.0 milestone Feb 2, 2017
shaka-bot pushed a commit that referenced this issue Feb 7, 2017
Issue #675

Change-Id: I0fe18ea28571ad2dd6c92587e5df345c80b223c6
joeyparrish pushed a commit that referenced this issue Feb 7, 2017
Issue #675

Change-Id: I0fe18ea28571ad2dd6c92587e5df345c80b223c6
joeyparrish added a commit that referenced this issue Feb 7, 2017
In v2.0.3, we broke the cast proxy by adding getPlayheadTimeAsDate,
which was never added to the v2.0.x branch.  (It will be released in
v2.1.0.)

Closes #675
@joeyparrish
Copy link
Member

Thanks again for the report. This was broken in v2.0.3 and will be fixed in v2.0.6.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants