Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casting unexpected stop #684

Closed
TigerHuang opened this issue Feb 5, 2017 · 4 comments
Closed

Casting unexpected stop #684

TigerHuang opened this issue Feb 5, 2017 · 4 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated

Comments

@TigerHuang
Copy link

TigerHuang commented Feb 5, 2017 •
edited

  • What version of Shaka Player are you using?
    2.0.5
  • Can you reproduce the issue with our latest release version?
    yes
  • Can you reproduce the issue with the latest code from master?
    yes
  • Are you using the demo app or your own custom app?
    yes
  • If custom app, can you reproduce the issue using our demo app?
    yes
  • What browser and OS are you using?
    Mac OS 10.12.3 Chrome 55.0.2883.95 (64-bit)
  • What did you do?
    • What content did you load?
      • If standard demo asset, which one?
        Cast demo asset: Live sim (2s segments) to my Chromecast ultra about 5 mins.
  • How did you interact with the content, if at all?
    nothing.
  • What did you expect to happen?
    keep casting.
  • What actually happened?
    casting stopped. Console Log display "No Period ID given for Period with start time 0, Assigning a default"
@TigerHuang TigerHuang changed the title Casting disconnect when No Period ID given for Period Casting unexpected stop Feb 5, 2017
@TigerHuang
Copy link
Author

console debug logs
screenshot 2017-02-08 00 31 24

@joeyparrish
Copy link
Member

@TheModMaker, can you try to reproduce?

@TigerHuang
Copy link
Author

I just try the last commit 56f6ef4 this bug still exist

@TheModMaker
Copy link
Contributor

This was a problem with the demo receiver app that runs on the Chromecast. I did a push to the nightly site so it should be working there. We will cherry-pick this to the v2.0.x branch and it will appear in the next bugfix release.

https://nightly-dot-shaka-player-demo.appspot.com/demo/

TheModMaker added a commit that referenced this issue Feb 24, 2017
@TheModMaker
Avoid duplicate idle timers in receiver app.
3f62693 
It is possible to call startIdleTimer_ multiple times in a row.  This
change makes sure that there is only one idle timer at a time.
Otherwise there is no way to cancel the other timers.

Closes #684

Change-Id: I264c7e2edadea76978c4f3848f27bb13c29510dd
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TigerHuang @TheModMaker @joeyparrish @shaka-bot