Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I get emsg messageData using compiled script? #717

Closed
miyukki opened this issue Mar 7, 2017 · 3 comments
Closed

How can I get emsg messageData using compiled script? #717

miyukki opened this issue Mar 7, 2017 · 3 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@miyukki
Copy link

miyukki commented Mar 7, 2017

  • What version of Shaka Player are you using?
    v2.0.6

    • Can you reproduce the issue with our latest release version?
      Yes, use dist/shaka-player.compiled.js.
    • Can you reproduce the issue with the latest code from master?
      No, use original source.
  • Are you using the demo app or your own custom app?
    my custon app

    • If custom app, can you reproduce the issue using our demo app?
      I'm not tried, maybe demo apps does not contain emsg box.
  • What browser and OS are you using?
    electron@v1.6.1

  • What did you do?
    I want to get emsg data via MP4 segments.
    But I can't get the messageData because shaka.dash.DashParser.EmsgInfo was compiled.

  • What did you expect to happen?

player.addEventListener('emsg', function(event) {
  // event.detail.messageData represents emsg data
});
  • What actually happened?
player.addEventListener('emsg', function(event) {
  // event.detail.pd represents emsg data
});

How can I get emsg messageData using compiled script? Or, do you have a best way to get?

TheModMaker added a commit that referenced this issue Mar 7, 2017
Having the EmsgInfo struct in DashParser means that the members can
be renamed.  However, since this is given in an event listener, the
fields shouldn't be renamed, so this moves the definition to externs.

Closes #717

Change-Id: Ieb00c629f496702963cd753fc14012bfd21f7ee1
@TheModMaker
Copy link
Contributor

This has been fixed in the master branch, so it will appear in v2.1. I have also pushed a change to the v2.0.x branch. You can pull that branch and build yourself if you want to use v2.0.x. It will appear in the next bugfix release (if we do one).

@joeyparrish
Copy link
Member

We will do a v2.0.7 release in the near future, with this and any other accumulated bug fixes. Thanks!

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Mar 7, 2017
@joeyparrish
Copy link
Member

This was just released in v2.0.7.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants