Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content not stored offline in demo. Manifest issue? #739

Closed
danyentezari opened this issue Mar 28, 2017 · 7 comments
Closed

Content not stored offline in demo. Manifest issue? #739

danyentezari opened this issue Mar 28, 2017 · 7 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.1.0

Comments

@danyentezari
Copy link

danyentezari commented Mar 28, 2017 •
edited by joeyparrish
Loading

- What version of Shaka Player are you using?
v2.0.0-debug

- Can you reproduce the issue with our latest release version?
The issue persists with Shaka Player v2.0.6-debug (hosted demo)

- Are you using the demo app or your own custom app?
The demo app, https://shaka-player-demo.appspot.com/demo/.

- What browser and OS are you using?
Google Chrome 57.0.2987.98, macOS Sierra 10.12.3.

- What did you do?
Tried to load custom asset and store offline.

- What content did you load?
https://s3.ap-south-1.amazonaws.com/debucket1/sample-dash/home/527379.mpd - Generated with Bitmovin

I did not enter a license server.

- What did you expect to happen?
The contents to be stored offline.

- What actually happened?
The window froze, 0% progress, and no console error. The video does play, however.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Mar 28, 2017
@joeyparrish
Copy link
Member

Wow, this hung my tab in Chrome. We will look into it. Thanks for the report!

@joeyparrish joeyparrish self-assigned this Mar 28, 2017
@joeyparrish
Copy link
Member

Infinite loop! 😱

When we build a list of segments to download, we ask the stream for the next segment until it returns null. This manifest uses SegmentTemplate, so a reference can be calculated for any segment number. But for VOD, we should take the period duration into account and not return references that should not exist.

@joeyparrish joeyparrish added this to the v2.1.0 milestone Mar 28, 2017
@danyentezari
Copy link
Author

v2.1.0? I'll switch to Shaka Packager, then.

For your reference, here's the link to download the Bitmovin encoding output:
https://we.tl/tqZyaCwPDB

Best of luck!

@joeyparrish
Copy link
Member

I'm putting it in the v2.1 milestone for tracking purposes, but we will cherry-pick the fix to our next bug fix release, v2.0.7.

joeyparrish added a commit that referenced this issue Mar 29, 2017
@joeyparrish
Do not construct infinite segment references
5f703a9 
This fixes an infinite loop when storing SegmentTemplate-based VOD
content.  In shaka.offline.Storage.prototype.createStream_, we loop
over all segment references to feed the download manager.  Those
references should stop at the period duration.

Closes #739

Change-Id: Ia16e89968b3bd8fc554b71ac857f8d9ae890cde1
@joeyparrish
Copy link
Member

This was just released in v2.0.7.

@danyentezari
Copy link
Author

@joeyparrish You are magnificent!

I really needed this to work 😄 .

@joeyparrish
Copy link
Member

We are always happy to help.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
3 participants
@danyentezari @joeyparrish @shaka-bot