Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to detect missing UHD keys in Sintel #761

Closed
joeyparrish opened this issue Apr 26, 2017 · 1 comment
Closed

Failed to detect missing UHD keys in Sintel #761

joeyparrish opened this issue Apr 26, 2017 · 1 comment
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.2.0

Comments

@joeyparrish
Copy link
Member

  • What version of Shaka Player are you using?
    v2.1.0 and v2.0.8

  • Are you using the demo app or your own custom app?
    demo app

  • What browser and OS are you using?
    Chrome Linux

  • What did you do?
    Load "Sintel (multicodec, Widevine)"

    • How did you interact with the content, if at all?
      Manually select 4k resolution

  • What did you expect to happen?
    We do not get UHD keys on Linux, so 4k should not be available.

  • What actually happened?
    We tried to play 4k and got stuck waiting for keys at 13 seconds

Investigation shows that the 4k track uses key ID "4d4b0ca25ac158f0b9c1983c517ee2b5", which was not present in the license. In spite of this, allowedByKeySystem is set to true.

This is true in both v2.0.8 and v2.1.0, so the fix should be backported to the v2.0.x branch.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Apr 26, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone Apr 26, 2017
@TheModMaker TheModMaker self-assigned this May 4, 2017
joeyparrish pushed a commit that referenced this issue May 8, 2017
@TheModMaker @joeyparrish
Restrict tracks that we don't have keys for.
aefb0d1 
There was a bug where not having a key for a track allowed it to be
played.  This was caused because we used to only pass the keys that
were updated to Player.  This meant that a missing key was
inconclusive.  But now we always pass every key we have; so if the key
isn't in the passed map, we don't have that key and we should restrict
that track.

Closes #761

Change-Id: I42bf5af1e0a62d97460356bba502a859c5970e1b
joeyparrish pushed a commit that referenced this issue May 10, 2017
@TheModMaker @joeyparrish
Restrict tracks that we don't have keys for.
ee12d9b 
There was a bug where not having a key for a track allowed it to be
played.  This was caused because we used to only pass the keys that
were updated to Player.  This meant that a missing key was
inconclusive.  But now we always pass every key we have; so if the key
isn't in the passed map, we don't have that key and we should restrict
that track.

Backported to v2.0.x

Closes #761

Change-Id: I42bf5af1e0a62d97460356bba502a859c5970e1b
@joeyparrish
Copy link
Member Author

This has been cherry-picked to v2.1.1 and v2.0.9.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
3 participants
@TheModMaker @joeyparrish @shaka-bot