Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poster shows through full screen #778

Closed
joeyparrish opened this issue May 4, 2017 · 1 comment
Closed

Poster shows through full screen #778

joeyparrish opened this issue May 4, 2017 · 1 comment
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.2.0

Comments

@joeyparrish
Copy link
Member

To reproduce:

  1. Run the demo.
  2. Select an asset that is a different aspect ratio than your screen. Sintel works for me, but Angel One has a different ratio if Sintel doesn't work for you.
  3. Click load.
  4. Click the fullscreen button.

The Shaka player poster shows through where there should be black bars.

This slipped in unnoticed in a060bf2 when we went from using poster= in the HTML to using background-image in CSS.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label May 4, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone May 4, 2017
@joeyparrish joeyparrish self-assigned this May 5, 2017
joeyparrish added a commit that referenced this issue May 8, 2017
@joeyparrish
Fix poster visibility in fullscreen mode
e487cad 
This reverts part of a060bf2, in which we stopped using the poster
attribute in favor of CSS background-image.  We are now using poster
again.  This fixes the visibility of the poster in fullscreen mode.

Closes #778
Fixes: 38004161

Change-Id: I4b8cbb771cd435a04dda5b298cf4daea0ed6f516
@joeyparrish
Copy link
Member Author

Cherry-picked to v2.1.1.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
2 participants
@joeyparrish @shaka-bot