Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player.load doesn't work with custom manifest retryParameters #782

Closed
avelad opened this issue May 5, 2017 · 2 comments
Closed

player.load doesn't work with custom manifest retryParameters #782

avelad opened this issue May 5, 2017 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@avelad
Copy link
Collaborator

avelad commented May 5, 2017

  • What version of Shaka Player are you using? v2.1.0

    • Can you reproduce the issue with our latest release version? Yes

    • Can you reproduce the issue with the latest code from master? Yes

  • Are you using the demo app or your own custom app? Custom

    • If custom app, can you reproduce the issue using our demo app? Yes, if iIchange the setupAssetMetadata config.
  • What browser and OS are you using? Chrome 58 - Ubuntu 17.04

  • What did you do?
    Use this config:

var config = /** @type {shakaExtern.PlayerConfiguration} */(
  {
    drm: {},
    manifest: {
      dash: {},
      retryParameters: {
        maxAttempts: 4,
        baseDelay: 1000,
        backoffFactor: 2,
        fuzzFactor: 0.5,
        timeout: 0
      }
    }
  }

I change maxAttempts to 4 (with 0, 1, 2 the error doesn't occur)

Load any url that returns 404 (https://storage.googleapis.com/shaka-demo-assets/sintel/dash1.mpd)
While the attemps happen, you need load another assets(that exists). Player.load does nothing

@joeyparrish
Copy link
Member

This is more difficult to reproduce in the latest code. We no longer continue to retry a manifest request on a 404 or 403 error. It is easier to reproduce now by setting a large maxAttempts (like 1000) and a small timeout (like 1 ms).

It seems that you are right. I'm not seeing any effect from player.load() while it is fetching a manifest.

@joeyparrish joeyparrish added type: bug Something isn't working correctly and removed needs triage labels Jun 6, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone Jun 6, 2017
@joeyparrish
Copy link
Member

A note for whoever picks up this bug: It would be ideal to start by writing a new test that reproduces this bug, perhaps in the 'load/unload' section of test/player_unit.js.

@TheModMaker TheModMaker self-assigned this Jun 7, 2017
joeyparrish pushed a commit that referenced this issue Jun 15, 2017
If you attempt to load an asset and then the first load fails, then
the second load will hang forever.  This was caused by the second load
trying to cancel the first, but the CancelableChain not handling this
case.

Closes #782

Change-Id: I79e201db44cbf47485e7221cc148bbfdde6276f7
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants