Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trackschanged event being triggered twice #783

Closed
hussam-i-am opened this issue May 5, 2017 · 4 comments
Closed

trackschanged event being triggered twice #783

hussam-i-am opened this issue May 5, 2017 · 4 comments
Assignees
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@hussam-i-am
Copy link

  • What version of Shaka Player are you using? 2.1.0

  • Can you reproduce the issue with our latest release version? Yes

  • Can you reproduce the issue with the latest code from master? Yes

  • Are you using the demo app or your own custom app? Both

  • If custom app, can you reproduce the issue using our demo app? Yes

  • What browser and OS are you using? MacOS/Chrome

  • What did you do? Added a trackschanged event listener

  • What content did you load? Angel One demo asset

  • How did you interact with the content, if at all? Loaded demo asset

  • What did you expect to happen? trackschanged event listeners should only be triggered once

  • What actually happened? trackschanged event listeners was triggered twice

@TheModMaker TheModMaker self-assigned this May 5, 2017
@TheModMaker TheModMaker added type: bug Something isn't working correctly flag: good first issue This might be a relatively easy issue; good for new contributors labels May 5, 2017
@TheModMaker TheModMaker added this to the v2.2.0 milestone May 5, 2017
@hussam-i-am
Copy link
Author

hussam-i-am commented May 5, 2017 via email

@joeyparrish
Copy link
Member

I'm planning to cherry-pick this to v2.1.1.

@hussam-i-am
Copy link
Author

Thanks, @joeyparrish and @TheModMaker

joeyparrish pushed a commit that referenced this issue May 8, 2017
Closes #783

Change-Id: If355acbe6df94e91fb818f344fff8d9d5d1910ac
@joeyparrish
Copy link
Member

Cherry-picked to v2.1.1.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants