Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrmEngine#unpackPlayReadyRequest fails in Tizen HTML5 application #814

Closed
chrisfillmore opened this issue May 17, 2017 · 6 comments
Closed
Assignees
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@chrisfillmore
Copy link
Contributor

chrisfillmore commented May 17, 2017

The Tizen PlayReady CDM doesn't wrap the license message in XML as other PlayReady CDMs do (i.e IE11, Edge). It can be delivered to the license server as-is.

The proposed fix is to add a check for wrapping in DrmEngine#unpackPlayReadyRequest. If the message is not wrapped, return early. I have submitted PR #815.

@chrisfillmore
Copy link
Contributor Author

chrisfillmore commented May 17, 2017

I just want to add a note: I am having an ongoing problem getting Shaka to run on Tizen in compiled mode. It compiles fine, but I have so far been unable to get the player to work in compiled mode on the TV. All my testing is done in uncompiled mode. I will be investigating this further.

@joeyparrish joeyparrish added the type: enhancement New feature or request label May 17, 2017
@joeyparrish joeyparrish self-assigned this May 17, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone May 17, 2017
@joeyparrish
Copy link
Member

Thank you for contributing! I will review your PR soon.

I am happy to help you with Tizen issues if I can. Unfortunately, I don't have access to a Tizen device for testing.

Please do file an issue with details on what goes wrong in compiled mode. When there are issues in compiled mode, the compiler is usually renaming something it should not. We can definitely help you fix that.

@chrisfillmore
Copy link
Contributor Author

Thanks Joey.

Also as a heads up -- all of my work / testing is in Tizen HTML5 application, i.e. not the Tizen web browser.

@joeyparrish
Copy link
Member

I admit, I'm not familiar with the distinction. But we'll try to do what we can to help, either way.

@chrisfillmore
Copy link
Contributor Author

The Tizen OS has a web browser, which I presume is like a regular browser. (I doubt anyone ever uses it.) But you can also develop native apps, either in an HTML5/JS environment or directly in C/C++.

@joeyparrish
Copy link
Member

This fix was just released in v2.1.2.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@joeyparrish joeyparrish added the platform: TV/STB Issues affecting smart TV or set-top box platforms label Jul 17, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants