Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate fields for audio and video bandwidth for variant tracks #834

Closed
DanielLindstrm opened this issue May 30, 2017 · 2 comments
Closed

Add separate fields for audio and video bandwidth for variant tracks #834

DanielLindstrm opened this issue May 30, 2017 · 2 comments
Assignees
@ismena
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.2.0

Comments

@DanielLindstrm
Copy link

What version of Shaka Player are you using:
2.1.2

Hi
I want to calculate MOS and I need the bitrate of the individual tracks.
In previous versions you could get audio / video tracks separately, but now you can only get the combined (variant track) as I understand it? Is it possible to get the bitrate for the individual tracks somehow?
@ismena
Copy link
Contributor

ismena commented May 30, 2017

Hi @DanielLindstrm,
We switched from individual audio/video tracks to variants(audio+video combinations) starting 2.1 when we added HLS support. (This is the way HLS is structured), so the bandwidth of a variant track will be the combined bandwidth of both audio and video.

That being said, I don't see why we couldn't add separate fields for audio and video bandwidth and fill them if we know this information (we will for DASH and won't for HLS).
Would that help?

Please note, that you still won't be able to select individual audio and video streams, but only their variant combinations.

@DanielLindstrm
Copy link
Author

Yes, it would help.
Thanks.

@joeyparrish joeyparrish added this to the Backlog milestone May 31, 2017
@joeyparrish joeyparrish added type: enhancement New feature or request flag: good first issue This might be a relatively easy issue; good for new contributors labels May 31, 2017
@ismena ismena changed the title How to get audio and video bitrate separate Add separate fields for audio and video bandwidth for variant tracks May 31, 2017
forbesjo pushed a commit to brightcove/shaka-player that referenced this issue Jul 10, 2017
@ismena
Add stream bandwidth info to variant tracks.
233abf7 
Closes shaka-project#834.

Change-Id: I3af66a227ad09f1686a7ca3f545c2bf9683d3c24
@forbesjo forbesjo mentioned this issue Jul 10, 2017
Merged
forbesjo pushed a commit to brightcove/shaka-player that referenced this issue Jul 10, 2017
@ismena
Add stream bandwidth info to variant tracks.
293fcde 
Closes shaka-project#834.

Change-Id: I3af66a227ad09f1686a7ca3f545c2bf9683d3c24
@joeyparrish joeyparrish modified the milestones: v2.2.0, Backlog Jul 12, 2017
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ismena ismena

Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
4 participants
@ismena @joeyparrish @DanielLindstrm @shaka-bot