Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayReady broken (in Edge and IE11) since 2.1.2 #837

Closed
Ambroos opened this issue May 31, 2017 · 2 comments
Closed

PlayReady broken (in Edge and IE11) since 2.1.2 #837

Ambroos opened this issue May 31, 2017 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Ambroos
Copy link

Ambroos commented May 31, 2017

Have you read the FAQ and checked for duplicate issues: yes

What version of Shaka Player are you using: 2.1.2

Can you reproduce the issue with our latest release version: yes

Can you reproduce the issue with the latest code from master: haven't checked (most likely yes)

Are you using the demo app or your own custom app: both

If custom app, can you reproduce the issue using our demo app: yes

What browser and OS are you using: Edge 38, IE11 (latest)

What are the manifest and license server URIs: any PlayReady demo in the Shaka demo page
(you can send the URIs to shaka-player-issues@google.com instead, but please use GitHub and the template for the rest)

What did you do?

  • Try to play a PlayReady-protected asset (Axinom and Tears of Steel) on the demo page
  • Try to play a PlayReady-protected asset of our own (CastLabs DRMtoday with PlayReady) in our own integration

What did you expect to happen?

  • The asset plays

What actually happened?

  • The license request is only a single starting XML starting thing (<) and doesn't contain the usual XML/SOAP body. (Both on the demo page and in our own custom integration.)

2.1.1 works fine (custom integration, exact same issue on 2.1.2).

The Chromecast PlayReady does work fine once I manually set the license request header Content-Type to text/xml (is text/html by default for some reason).

@Ambroos Ambroos changed the title PlayReady (in Edge and IE11) broken since 2.1.2 PlayReady broken (in Edge and IE11) since 2.1.2 May 31, 2017
joeyparrish referenced this issue May 31, 2017
The PlayReady server at Axinom is failing with HTTP 500, so for now,
we will disable these tests on PlayReady.

Change-Id: Ife0365669376af0fd437798a501b79a9bc0b3eab
@joeyparrish joeyparrish added type: bug Something isn't working correctly needs triage labels May 31, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone May 31, 2017
@joeyparrish joeyparrish self-assigned this Jun 2, 2017
@joeyparrish
Copy link
Member

Looks like this was caused by PR #815. I mistakenly disabled the relevant tests in c263e0b. I should have realized that we broke it, but I was distrustful of a failure from a third-party server.

I'll see what I can do to fix it. Thanks!

joeyparrish added a commit that referenced this issue Jun 5, 2017
We broke PlayReady on IE and Edge in #815 when we fixed PlayReady for
Tizen.  This should work for both, but will still need to be tested on
Tizen after merging.

Closes #837

Change-Id: Iff41845ae6a4b369e8f21a80623ebb2cb5475fd6
@joeyparrish
Copy link
Member

Cherry-picked to v2.1.3.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants