Regression - choose lowest-bandwidth codec when the browser can do multiple #841
Assignees
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
shaka-bot
pushed a commit
that referenced
this issue
Jun 5, 2017
- Make FakeStreamingEngine injectable by removing Period argument
- FakeStreamingEngine can now have its spies manipulated before we
call player.load().
- Do not poke into player's manifest_ and streamingEngine_ members in
chooseStreams(), since load() sets those already.
- Instead of setting activeStreams in the constructor, set them in
init(). This is a more accurate fake, and this is important for
upcoming tests related to early filtering, since filtering takes
into account the active streams.
Leads into a fix for #841
Change-Id: Ia893053490cde819e32907c7a1a2030c29022f62
joeyparrish
added a commit
that referenced
this issue
Jun 5, 2017
- Make FakeStreamingEngine injectable by removing Period argument
- FakeStreamingEngine can now have its spies manipulated before we
call player.load().
- Do not poke into player's manifest_ and streamingEngine_ members in
chooseStreams(), since load() sets those already.
- Instead of setting activeStreams in the constructor, set them in
init(). This is a more accurate fake, and this is important for
upcoming tests related to early filtering, since filtering takes
into account the active streams.
Leads into a fix for #841
Change-Id: Ia893053490cde819e32907c7a1a2030c29022f62
joeyparrish
added a commit
that referenced
this issue
Jun 5, 2017
Before asking AbrManager to choose streams, we should choose codecs. Choose the most efficient codecs, and do it after we have filtered out the codecs that the platform cannot use. Closes #841 Change-Id: Ifbdd22b33254d4584f77db6456ab238f7c04c755
|
Cherry-picked to v2.1.3. |
This was referenced Jun 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I seem to recall that we used to choose codecs based on lowest average bandwidth. Choosing codecs by bandwidth would allow us to prefer, for example, VP9 over H.264 when it would save bandwidth.
Since then, it seems we have regressed. We currently have no way to prefer codecs based on bandwidth. Once the initial selection has been made, we stick with it, but the initial selection is based on available bandwidth only. If there is much bandwidth available, we wind up choosing the least efficient streams.
To reproduce:
debugConfig = { abr: { defaultBandwidthEstimate: Infinity }};The system will choose h.264, even though vp9 could have been played and would have saved bandwidth.
The text was updated successfully, but these errors were encountered: