Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromecast PlayReady license request is sent with Content-Type: text/html #852

Closed
Ambroos opened this issue Jun 6, 2017 · 2 comments
Closed
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Ambroos
Copy link

Ambroos commented Jun 6, 2017

Have you read the FAQ and checked for duplicate issues: yes

What version of Shaka Player are you using: 2.1.3

Can you reproduce the issue with our latest release version: yes

Can you reproduce the issue with the latest code from master: unknown

Are you using the demo app or your own custom app: custom app - cannot access Chromecast remote debugging in demo app

If custom app, can you reproduce the issue using our demo app: N/A

What browser and OS are you using: Chromecast 2

What are the manifest and license server URIs:
Cannot provide at this point (our signed licenses expire after 5 minutes) but it wouldn't surprise me if it was reproducible with the PlayReady test assets in the demo (which error when casting as well).

We use DRMtoday with both PlayReady and Widevine schemes in our manifests.

What did you do?
Play a DASH video that supports both PlayReady and Widevine on a Chromecast 2

What did you expect to happen?
The license request (either PlayReady or Widevine) should succeed and the video should play.

What actually happened?
The license request failed with a 415 unsupported media type, as it is sent with Content-Type: text/html.

Manually adding request.headers['Content-Type'] = 'text/xml; charset=utf-8'; to the license request filter resolves the issue (as does removing PlayReady license servers from the configuration to make Shaka use Widevine instead, which works fine).

The exact same code works fine in Edge/IE11 with PlayReady (in 2.1.1 / 2.1.3).

I suspect the issue is caused by the correct header not being added in https://github.com/google/shaka-player/blob/9d9d1c70/lib/media/drm_engine.js#L1122

@joeyparrish
Copy link
Member

@joeyparrish joeyparrish self-assigned this Jun 6, 2017
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jun 6, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone Jun 6, 2017
@joeyparrish
Copy link
Member

I did some debugging on a Chromecast and found that we never entered that method. It should be easy to fix. Sorry for the inconvenience.

joeyparrish added a commit that referenced this issue Jun 15, 2017
Closes #852

Change-Id: Ic3d87e5ad2339ff0a03ce550a1930b99b22ba8ca
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants