Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected "There is a gap/overlap between Periods" #909

Closed
sandersaares opened this issue Jun 26, 2017 · 1 comment
Closed

Unexpected "There is a gap/overlap between Periods" #909

sandersaares opened this issue Jun 26, 2017 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@sandersaares
Copy link
Contributor

sandersaares commented Jun 26, 2017

Have you read the FAQ and checked for duplicate issues: no

What version of Shaka Player are you using: 2.1.4-debug

Can you reproduce the issue with our latest release version: unknown

Can you reproduce the issue with the latest code from master: unknown

Are you using the demo app or your own custom app: shaka-player-demo.appspot.com

If custom app, can you reproduce the issue using our demo app: N/A

What browser and OS are you using: Chrome 58 on Windows 10.

What are the manifest and license server URIs: https://media.axprod.net/TestVectors/v8-MultiContent/Clear/Manifest.mpd

Detailed content description available at https://github.com/Axinom/dash-test-vectors

What did you do?
Pressed the Load button

What did you expect to happen?

Video plays without any errors/warnings.

What actually happened?

On manifest load, I get a warning saying There is a gap/overlap between Periods in the console. This is unexpected, as the timing appears correct based on my quick back of the envelope math.

Exploration of the variables involved shows the comparison leading to the warning is between periodDuration = 10.197000000000344, givenDuration = 10.197 which makes me think some floating point shenanigans is to blame.

Possibly related: #882

@TheModMaker TheModMaker self-assigned this Jul 5, 2017
@TheModMaker TheModMaker added type: bug Something isn't working correctly and removed needs triage labels Jul 5, 2017
@TheModMaker TheModMaker added this to the v2.2.0 milestone Jul 5, 2017
joeyparrish pushed a commit that referenced this issue Jul 17, 2017
Closes #882
Closes #909
Closes #911

Change-Id: Id31567137860b6bd683169b5b68ca83d6f14473d
@joeyparrish
Copy link
Member

The fix for this has been cherry-picked and will be released in v2.1.5.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

5 participants