Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfills being run more than once #941

Closed
gscragg opened this issue Jul 24, 2017 · 4 comments
Closed

Polyfills being run more than once #941

gscragg opened this issue Jul 24, 2017 · 4 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@gscragg
Copy link
Contributor

gscragg commented Jul 24, 2017

I have noticed an issue in IE11 with the InputEvent polyfill, where if shaka.polyfills.installAll() is called multiple times, a stack overflow error occurs when adding a change event handler to an input type="range".

Previously there there didn't seem to be an issue if we have 2 calls to installAll.

Should I be more careful around when and how this is called?

@joeyparrish joeyparrish self-assigned this Jul 24, 2017
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jul 24, 2017
@joeyparrish
Copy link
Member

@gscragg, it was never intended that you would call installAll() more than once, but I can't think of any reason it shouldn't still be safe. I'll see if I can fix it.

@joeyparrish joeyparrish added this to the v2.2.0 milestone Jul 24, 2017
@joeyparrish
Copy link
Member

We've pushed a fix. Please let us know how it works for you.

@gscragg
Copy link
Contributor Author

gscragg commented Jul 24, 2017

Thanks @joeyparrish, I appreciate your speedy response.

joeyparrish added a commit that referenced this issue Jul 25, 2017
Closes #941

Change-Id: I706aadd1bfc2c477d0ac8a0dff13defad74b3bda
@joeyparrish
Copy link
Member

The fix has been cherry-picked for v2.1.6.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants