Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playready license server URL update #945

Closed
BucherTomas opened this issue Jul 26, 2017 · 4 comments · Fixed by #953
Closed

Playready license server URL update #945

BucherTomas opened this issue Jul 26, 2017 · 4 comments · Fixed by #953
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.2.0

Comments

@BucherTomas
Copy link
Contributor

With the move of Shaka demo to https, it is necessary to update URL of Playready license server in assets.js. The older server playready.directtaps.net does not support https and is no longer updated, test.playready.microsoft.com supports https and should be used from now on, please see http://playready.directtaps.net/ .

The full license server URL for Tears of Steel (PlayReady) asset should be updated to
//test.playready.microsoft.com/service/rightsmanager.asmx?PlayRight=1&UseSimpleNonPersistentLicense=1
@joeyparrish
Copy link
Member

Thanks! Would you care to send a PR?

@joeyparrish joeyparrish added type: bug Something isn't working correctly flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this labels Jul 26, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone Jul 26, 2017
@BucherTomas
Copy link
Contributor Author

One of you in the Shaka team can replace the URL with the one above and commit it in two minutes flat :) .

No need to add myself with that one line to the contributors which, from what I gathered, is a mandatory step for PR.

@joeyparrish
Copy link
Member

No contribution is too small!

@BucherTomas BucherTomas mentioned this issue Jul 27, 2017
Merged
vaage pushed a commit that referenced this issue Jul 27, 2017
@BucherTomas @vaage
Update Playready test LAURL (#953)
4baf87e 
Replacing of deprecated Playready test license server in Shaka Demo App.

closes #945
joeyparrish pushed a commit that referenced this issue Aug 3, 2017
@BucherTomas @joeyparrish
Update Playready test LAURL (#953)
57fd4e9 
Replacing of deprecated Playready test license server in Shaka Demo App.

closes #945
@joeyparrish
Copy link
Member

This has been cherry-picked for v2.1.6.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Update Playready test LAURL BucherTomas/shaka-player
3 participants
@joeyparrish @shaka-bot @BucherTomas