Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari: CC/subtitles broken #991

Closed
bhh1988 opened this issue Aug 26, 2017 · 2 comments
Closed

Safari: CC/subtitles broken #991

bhh1988 opened this issue Aug 26, 2017 · 2 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@bhh1988
Copy link
Contributor

bhh1988 commented Aug 26, 2017

I am on Safari 10.1.2, and HEAD of master.

When I try to load a video with VTT subtitles declared in the manifest (using BaseURL, not segmented, but I doubt it matters), there is an error thrown on simple_text_displayer.js:194.

  if (shakaCue.textAlign == 'center' && vttCue.align != 'center') {
    // Workaround for a Chrome bug http://crbug.com/663797
    // Chrome does not support align = 'center'
    vttCue.position = 'auto';
    vttCue.align = 'middle';
  }

The error thrown says "The provided value is non-finite". I think it's similar to this issue here: mozilla/vtt.js#364

And then subtitles aren't shown on Safari at all, though the video/audio will continue playing.

@joeyparrish
Copy link
Member

We need to reproduce locally, file a bug on Apple if there isn't one yet, then work on a polyfill for Safari to fix it in JS. Thanks for the report!

@joeyparrish
Copy link
Member

The fix will be cherry-picked to v2.2.2.

joeyparrish pushed a commit that referenced this issue Sep 26, 2017
It appears there are different behaviours for text cues on
safari compared to other browsers. We were using "auto" for
position, but Safari does not support setting that value for
position. The spec says that the default value is "auto", so
by not setting it, we can assume that it will be "auto".

Closes #991
Closes #1012

Change-Id: Ibedc5f01f72138df85b911bb5112d40f2f327ad3
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants