defer assigning to video.currentTime Fixes #101 #103
Conversation
|
ready for rereview @joeyparrish |
|
rereview? @joeyparrish |
| @@ -1110,7 +1110,17 @@ shaka.player.StreamVideoSource.prototype.startStreams_ = function( | |||
| // Set the video's current time before starting the streams so that the | |||
| // streams begin buffering at the stream start time. | |||
| shaka.log.info('Starting each stream from', streamStartTime); | |||
| this.video.currentTime = streamStartTime; | |||
|
|
|||
| function setInitialCurrentTime() { | |||
There was a problem hiding this comment.
If this is run in the context of video, please annotate with @this {!HTMLVideoElement}. Alternately, use bind and run it in the context of StreamVideoSource.
|
rereview? @joeyparrish , double check the annotations, I've never written them before. Guessing they're used for closure compiler. |
| * @param {number} streamStartTime | ||
| * @private | ||
| */ | ||
| shaka.player.StreamVideoSource.prototype.setInitialCurrentTime = function( |
There was a problem hiding this comment.
Run the compiler & linter with build/all.sh. It will complain that this doesn't end in an underscore, which is the style we follow for private functions.
|
Thanks for the revisions. I really appreciate you working on this patch. |
Fixes shaka-project#101 Required for Firefox's and IE's MediaElement implementations.
|
made use of EventManager. rereview? @joeyparrish |
|
Looks good to me. Would you please give a quick read through CONTRIBUTING? You'll need to sign the license agreement, and add yourself to AUTHORS & CONTRIBUTORS. |
|
@joeyparrish , done. rereview? |
|
Excellent. Thanks for your contribution! |
defer assigning to video.currentTime Fixes #101
|
Hi Nick, sorry to have to say, but this patch breaks live streaming. You can see this by running this subset of the integration tests: spec_runner.html?spec=Player%20live The symptom is that these live streams simply do not start at all, at least on Chrome. Unfortunately, I have to revert your patch. I really do appreciate you getting Shaka Player working nicely on Firefox, and I hope you're still willing to try again when you have the time. |
|
No problema, about to hop a plane for a company work week, but I'd like to see this project working in FF, even if I have to write the patches. Will take a look later. |
|
Thanks, Nick. We want to see this working well on Firefox, too, but haven't been able to make it a priority yet to figure out why Firefox's HTML5/MSE implementation seems to behave a little bit differently from Chrome's. So your efforts are much appreciated. |
github-actions
bot
added
the
status: archived
Tested in FF (Nightly), Opera (Beta), and Safari