Add player method to set playback start time ahead of downloading chunks #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -168,6 +171,13 @@ shaka.player.HttpVideoSource.prototype.enableTextTrack = function(enabled) { | |||
|
|
|||
|
|
|||
| /** @override */ | |||
| shaka.player.HttpVideoSource.prototype.setPlaybackStartTime = | |||
| function(startTime) { | |||
| this.playbackStartTime_ = startTime; | |||
There was a problem hiding this comment.
Either this should be a no-op for HttpVideoSource, or this value should be used to set video.currentTime in attach().
There was a problem hiding this comment.
Okay, I've changed to a no-op.
|
Testing in progress... |
|
I'm going to try out the new CI system on you. |
|
All tests passed! |
|
Woohoo! |
|
Okay, I'm turning it over to Tim to finish review. |
tdrews
added a commit
that referenced
this pull request
Jul 13, 2015
Add player method to set playback start time ahead of downloading chunks
|
Thanks for taking care of this! |
11 tasks
joeyparrish
added a commit
that referenced
this pull request
Mar 21, 2022
The "if" fields do not need to use expression syntax (`${{ }}`), and
some conditionals will be easier to read if we omit that.
<!--
Please remember to:
1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)
You may delete this comment from the PR description.
-->
joeyparrish
added a commit
that referenced
this pull request
Mar 22, 2022
This release-please config file is a temporary measure until our first automated feature release from main. So we have to explicitly state the version number for this first release, and keep it up-to-date. After the release, we should be able to remove this file and let the workflow decide on version numbers automatically based on commit messages. <!-- Please remember to: 1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and PR title (https://www.conventionalcommits.org/) 2. Tag any related or fixed issues ("Issue #123", "Closes #420") 3. Sign the Google CLA if you haven't (https://cla.developers.google.com) You may delete this comment from the PR description. -->
joeyparrish
added a commit
that referenced
this pull request
Mar 22, 2022
The "if" fields do not need to use expression syntax (`${{ }}`), and
some conditionals will be easier to read if we omit that.
<!--
Please remember to:
1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)
You may delete this comment from the PR description.
-->
joeyparrish
added a commit
that referenced
this pull request
Mar 22, 2022
The "if" fields do not need to use expression syntax (`${{ }}`), and
some conditionals will be easier to read if we omit that.
<!--
Please remember to:
1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and
PR title (https://www.conventionalcommits.org/)
2. Tag any related or fixed issues ("Issue #123", "Closes #420")
3. Sign the Google CLA if you haven't (https://cla.developers.google.com)
You may delete this comment from the PR description.
-->
joeyparrish
added a commit
that referenced
this pull request
Mar 24, 2022
6f274cb dropped a deprecated Closure build tool, but also upgraded the Closure compiler and Closure library. This introduced a failure caused by a duplicate extern in the newer compiler. This drops the now-unnecessary extern. <!-- Please remember to: 1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and PR title (https://www.conventionalcommits.org/) 2. Tag any related or fixed issues ("Issue #123", "Closes #420") 3. Sign the Google CLA if you haven't (https://cla.developers.google.com) You may delete this comment from the PR description. -->
theodab
added a commit
that referenced
this pull request
Apr 11, 2022
The script for deploying the demo version index page has a function that chooses which versions to display. This script has a special mode meant for testing that shows a default list of demo versions. This mode was only supposed to trigger when run locally, but the check did not work properly, so the demo version index was deploying with a very out-of-date list of versions. This fixes that check. Closes #4074 <!-- Please remember to: 1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and PR title (https://www.conventionalcommits.org/) 2. Tag any related or fixed issues ("Issue #123", "Closes #420") 3. Sign the Google CLA if you haven't (https://cla.developers.google.com) You may delete this comment from the PR description. -->
joeyparrish
pushed a commit
that referenced
this pull request
Apr 21, 2022
The script for deploying the demo version index page has a function that chooses which versions to display. This script has a special mode meant for testing that shows a default list of demo versions. This mode was only supposed to trigger when run locally, but the check did not work properly, so the demo version index was deploying with a very out-of-date list of versions. This fixes that check. Closes #4074 <!-- Please remember to: 1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and PR title (https://www.conventionalcommits.org/) 2. Tag any related or fixed issues ("Issue #123", "Closes #420") 3. Sign the Google CLA if you haven't (https://cla.developers.google.com) You may delete this comment from the PR description. -->
avelad
pushed a commit
that referenced
this pull request
May 19, 2022
This new configuration value allows users to determine how far the video seeks when you press the arrow keys on the video element. Closes #4245 <!-- Please remember to: 1. Use Conventional Commits syntax (fix: ..., feat: ..., etc.) in commits and PR title (https://www.conventionalcommits.org/) 2. Tag any related or fixed issues ("Issue #123", "Closes #420") 3. Sign the Google CLA if you haven't (https://cla.developers.google.com) You may delete this comment from the PR description. -->
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.