Change so that default presentation delay for DASH is configurable #1234

[ghost]

The DEFAULT_SUGGESTED_PRESENTATION_DELAY_ in DashParser is useful to have configurable
when the stream provider isn't able to add suggestedPresentationDelay in the manifest.

Fixes #1234

[joeyparrish]

Looks great otherwise! I'll go ahead and run the tests in the build bot.

[joeyparrish]

typo: "biggar" should be "bigger"

[shaka-bot]

Test Failure:

Generating Closure dependencies...
Running Closure linter...
205 files checked, no errors found.
Running htmlhint...

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Config loaded: /var/lib/jenkins/workspace/Manual PR Test (local-tests)/.htmlhintrc

Scanned 3 files, no errors found (28 ms).
Checking that the build files are complete...
Checking the tests for type errors...
Checking the usability of generated externs...
Compiling the library (debug)...
Compiling the demo app (debug)...
Compiling the receiver app (debug)...
Compiling the library (release)...
Compiling the demo app (release)...
Compiling the receiver app (release)...
Building the docs...
ERROR: Unable to create a Tag object for source file /var/lib/jenkins/workspace/Manual PR Test (local-tests)/externs/shaka/player.js with title "typedef" and body " {{
customScheme: shakaExtern.DashContentProtectionCallback,
clockSyncUri: string,
ignoreDrmInfo: boolean,
xlinkFailGracefully: boolean,
defaultPresentationDelay: number,
}}

": Invalid type expression "{
customScheme: shakaExtern.DashContentProtectionCallback,
clockSyncUri: string,
ignoreDrmInfo: boolean,
xlinkFailGracefully: boolean,
defaultPresentationDelay: number,
}": Expected "!", "$", "'", "(", "*", "...", "?", "Function", "\"", "\\", "_", "break", "case", "catch", "class", "const", "continue", "debugger", "default", "delete", "do", "else", "enum", "export", "extends", "false", "finally", "for", "function", "if", "implements", "import", "in", "instanceof", "interface", "let", "new", "null", "package", "private", "protected", "public", "return", "static", "super", "switch", "this", "throw", "true", "try", "typeof", "undefined", "var", "void", "while", "with", "yield", "{", Unicode letter number, Unicode lowercase letter, Unicode modifier letter, Unicode other letter, Unicode titlecase letter or Unicode uppercase letter but "}" found.
ERROR: Unable to create a Tag object for source file /var/lib/jenkins/workspace/Manual PR Test (local-tests)/externs/shaka/player.js with title "typedef" and body " {{
customScheme: shakaExtern.DashContentProtectionCallback,
clockSyncUri: string,
ignoreDrmInfo: boolean,
xlinkFailGracefully: boolean,
defaultPresentationDelay: number,
}}

": Invalid type expression "{
customScheme: shakaExtern.DashContentProtectionCallback,
clockSyncUri: string,
ignoreDrmInfo: boolean,
xlinkFailGracefully: boolean,
defaultPresentationDelay: number,
}": Expected "!", "$", "'", "(", "*", "...", "?", "Function", "\"", "\\", "_", "break", "case", "catch", "class", "const", "continue", "debugger", "default", "delete", "do", "else", "enum", "export", "extends", "false", "finally", "for", "function", "if", "implements", "import", "in", "instanceof", "interface", "let", "new", "null", "package", "private", "protected", "public", "return", "static", "super", "switch", "this", "throw", "true", "try", "typeof", "undefined", "var", "void", "while", "with", "yield", "{", Unicode letter number, Unicode lowercase letter, Unicode modifier letter, Unicode other letter, Unicode titlecase letter or Unicode uppercase letter but "}" found.
END-BUILD: FAILURE
Build step 'Execute shell' marked build as failure

[joeyparrish]

It looks like jsdoc doesn't like your trailing comma in the doc string. I'll file a bug to make jsdoc more flexible, as trailing commas are recommended in other contexts.

[ghost]

@joeyparrish
I've amended the commit resolving the issues, removed the trailing comma and fixed the spelling mistake :)
Is there a command I should've run to see the jsdoc error? I ran ./build/all.py and ./build/test.py and didn't get that error 🤔

[joeyparrish]

Yes ./build/docs.py will build the documentation. It is a little silly and counterintuitive that all.py doesn't include docs.py, but we reasoned that someone who wants to rebuild the code all the time during development won't want to rebuild the docs all the time. I'm honestly unsure what the best change would be to improve that.

[shaka-bot]

All tests passed!

[joeyparrish]

Okay, everything looks good! Thanks!

[joeyparrish]

Cherry-picked for v2.3.2. Just barely missed the cut-off for v2.3.1. Thanks again for the contribution!