Rename Timeline related events to include the "Event" suffix used throughout the rest of the project #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the timeline related events are the only events defined without an "Event"-suffix in the name. Their naming should follow the naming used throughout the rest of the project.
Add Alugha GmbH to AUTHORS and Niklas Korz to CONTRIBUTORS.
|
Makes sense to me. Thanks! Just running it through the build bot before we merge it. |
|
All tests passed! |
|
Thanks for your contribution! |
|
Cherry-picked to v2.3.2 |
joeyparrish
pushed a commit
that referenced
this pull request
Feb 1, 2018
Right now, the timeline related events are the only events defined without an "Event"-suffix in the name. Their naming should follow the naming used throughout the rest of the project.
hussam-i-am
added a commit
to jwplayer/shaka-player
that referenced
this pull request
Feb 8, 2018
* upstream/master: (87 commits) Turn warnings into errors in jsdoc Make net engine returns error when out of retries Ignore HLS text streams when calculating duration. Fix typo in shakaExterns.Track docs (shaka-project#1274) Fix documentation typos (shaka-project#1272) Support CEA 708 Closed Captions Sort jsdoc tutorials according to the config file Fix jsdoc linksource error on bad markdown escape Improve annotations and docs for PublicPromise Improve annotations and docs for TtmlTextParser Show more verbose functions and records in docs Allow the user to show/hide parts of the docs Update changelog for v2.3.2 Handle UNSUPPORTED_UPGRADE_REQUEST in the demo app Rename Timeline events to include the "Event" suffix (shaka-project#1267) Fix SegmentTemplate w/ duration. Add linksource tag to jsdoc Show jsdoc enum values and allow focus from URL Tweak jsdoc formatting Add jsdoc metadata for interface implementations ...
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very small change, I acknowledge, but while writing type definitions for using shaka-player with our TypeScript codebase, I came accross this one.
TimelineRegionAdded, TimelineRegionEnter and TimelineRegionExit are the only events to miss the "Event" suffix.
As this is indeed a very small change I do not think this justifies opening an issue next to this pull request.