Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove misleading logging in DrmEngine#fillInDrmInfoDefaults_ #1288

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Remove misleading logging in DrmEngine#fillInDrmInfoDefaults_ #1288

merged 2 commits into from
Feb 20, 2018

Conversation

chrisfillmore
Copy link
Contributor

Closes #1284

@shaka-bot
Copy link
Collaborator

Test Failure:

Chrome 64.0.3282 (Linux 0.0.0)
  DrmEngine init fails if license server is not configured FAILED
    Expected spy shaka.log.error to have been called.
        at test/media/drm_engine_unit.js:505:29
        at <anonymous>

Failed 1 tests, passed 1321, skipped 45

@joeyparrish
Copy link
Member

Could you update that test as well? Thanks!

@joeyparrish joeyparrish added this to the v2.4.0 milestone Feb 9, 2018
@joeyparrish joeyparrish added the type: enhancement New feature or request label Feb 9, 2018
@joeyparrish joeyparrish self-assigned this Feb 9, 2018
@chrisfillmore
Copy link
Contributor Author

Sorry for missing that!

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 792775c into shaka-project:master Feb 20, 2018
@joeyparrish
Copy link
Member

Merged. Thanks!

joeyparrish pushed a commit that referenced this pull request Feb 21, 2018
@chrisfillmore @joeyparrish
Remove misleading logging in DrmEngine#fillInDrmInfoDefaults_ (#1288)
27a0ed7 
Closes #1284
@joeyparrish
Copy link
Member

Cherry-picked for v2.3.3.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@shanmugapriyaEK shanmugapriyaEK shanmugapriyaEK approved these changes

Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrisfillmore @shaka-bot @joeyparrish @shanmugapriyaEK