Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1317 - Warn if we don't get a valid date from UTCTiming server. #1318

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Issue #1317 - Warn if we don't get a valid date from UTCTiming server. #1318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/dash/dash_parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,15 +1440,21 @@ shaka.dash.DashParser.prototype.requestForTiming_ =
return operation.promise.then((response) => {
let text;
if (method == 'HEAD') {
if (!response.headers || !response.headers['date']) return 0;

if (!response.headers || !response.headers['date']) {
shaka.log.warning('UTC timing response is missing',
'expected date header');
return 0;
}
text = response.headers['date'];
} else {
text = shaka.util.StringUtils.fromUTF8(response.data);
}

let date = Date.parse(text);
return isNaN(date) ? 0 : (date - Date.now());
if (isNaN(date)) {
shaka.log.warning('Unable to parse date from UTC timing response');
return 0;
}
return (date - Date.now());
});
};

Expand Down